From: Daniel Vetter <daniel@ffwll.ch>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 3/3] drm: Make drm_av_sync_delay() 'mode' argument const
Date: Wed, 9 Sep 2015 14:54:24 +0200 [thread overview]
Message-ID: <20150909125424.GI2767@phenom.ffwll.local> (raw)
In-Reply-To: <CADnq5_MabY-3S4LeyL=qXhoVUc0joKEAO0MXnn9ZmodxGCB=QQ@mail.gmail.com>
On Wed, Sep 09, 2015 at 08:45:14AM -0400, Alex Deucher wrote:
> On Mon, Sep 7, 2015 at 11:22 AM, <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > drm_av_sync_delay() doesn't change the passed in mode, so make it const.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> For the series:
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Applied to drm-misc, thanks for patches&review.
-Daniel
>
> > ---
> > drivers/gpu/drm/drm_edid.c | 2 +-
> > include/drm/drm_edid.h | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> > index e32218f..d895556 100644
> > --- a/drivers/gpu/drm/drm_edid.c
> > +++ b/drivers/gpu/drm/drm_edid.c
> > @@ -3361,7 +3361,7 @@ EXPORT_SYMBOL(drm_edid_to_speaker_allocation);
> > * the sink doesn't support audio or video.
> > */
> > int drm_av_sync_delay(struct drm_connector *connector,
> > - struct drm_display_mode *mode)
> > + const struct drm_display_mode *mode)
> > {
> > int i = !!(mode->flags & DRM_MODE_FLAG_INTERLACE);
> > int a, v;
> > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h
> > index 31528d9..2af9769 100644
> > --- a/include/drm/drm_edid.h
> > +++ b/include/drm/drm_edid.h
> > @@ -326,7 +326,7 @@ void drm_edid_to_eld(struct drm_connector *connector, struct edid *edid);
> > int drm_edid_to_sad(struct edid *edid, struct cea_sad **sads);
> > int drm_edid_to_speaker_allocation(struct edid *edid, u8 **sadb);
> > int drm_av_sync_delay(struct drm_connector *connector,
> > - struct drm_display_mode *mode);
> > + const struct drm_display_mode *mode);
> > struct drm_connector *drm_select_eld(struct drm_encoder *encoder);
> > int drm_load_edid_firmware(struct drm_connector *connector);
> >
> > --
> > 2.4.6
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/dri-devel
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-09-09 12:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 15:22 [PATCH 1/3] drm: Make some modes const when iterating through them ville.syrjala
2015-09-07 15:22 ` [PATCH 2/3] drm: Remove the 'mode' argument from drm_select_eld() ville.syrjala
2015-09-07 15:22 ` [PATCH 3/3] drm: Make drm_av_sync_delay() 'mode' argument const ville.syrjala
2015-09-09 12:45 ` Alex Deucher
2015-09-09 12:54 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150909125424.GI2767@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox