From: Daniel Vetter <daniel@ffwll.ch>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: don't try to load GuC fw on pre-gen9
Date: Mon, 14 Sep 2015 11:26:55 +0200 [thread overview]
Message-ID: <20150914092654.GV3383@phenom.ffwll.local> (raw)
In-Reply-To: <1441922100-3039-1-git-send-email-jbarnes@virtuousgeek.org>
On Thu, Sep 10, 2015 at 02:55:00PM -0700, Jesse Barnes wrote:
> This avoids some bad register writes and generally feels more correct
> than unconditionally trying to redirect interrupts and such.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=91777
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Queued for -next, thanks for the patch.
-Daniel
> ---
> drivers/gpu/drm/i915/i915_gem.c | 29 ++++++++++++++++-------------
> 1 file changed, 16 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index 41263cd..fc3a5fd 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -4691,19 +4691,22 @@ i915_gem_init_hw(struct drm_device *dev)
> }
>
> /* We can't enable contexts until all firmware is loaded */
> - ret = intel_guc_ucode_load(dev);
> - if (ret) {
> - /*
> - * If we got an error and GuC submission is enabled, map
> - * the error to -EIO so the GPU will be declared wedged.
> - * OTOH, if we didn't intend to use the GuC anyway, just
> - * discard the error and carry on.
> - */
> - DRM_ERROR("Failed to initialize GuC, error %d%s\n", ret,
> - i915.enable_guc_submission ? "" : " (ignored)");
> - ret = i915.enable_guc_submission ? -EIO : 0;
> - if (ret)
> - goto out;
> + if (HAS_GUC_UCODE(dev)) {
> + ret = intel_guc_ucode_load(dev);
> + if (ret) {
> + /*
> + * If we got an error and GuC submission is enabled, map
> + * the error to -EIO so the GPU will be declared wedged.
> + * OTOH, if we didn't intend to use the GuC anyway, just
> + * discard the error and carry on.
> + */
> + DRM_ERROR("Failed to initialize GuC, error %d%s\n", ret,
> + i915.enable_guc_submission ? "" :
> + " (ignored)");
> + ret = i915.enable_guc_submission ? -EIO : 0;
> + if (ret)
> + goto out;
> + }
> }
>
> /* Now it is safe to go back round and do everything else: */
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-09-14 9:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 21:55 [PATCH] drm/i915: don't try to load GuC fw on pre-gen9 Jesse Barnes
2015-09-14 9:26 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914092654.GV3383@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox