From: Daniel Vetter <daniel@ffwll.ch>
To: "Kamble, Sagar A" <sagar.a.kamble@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
Mika Kuoppala <mika.kuoppala@intel.com>,
"Hiremath, Shashidhar" <shashidhar.hiremath@intel.com>
Subject: Re: [PATCH 5/6] drm/i915/gen9: WA ST Unit Power Optimization Disable
Date: Mon, 14 Sep 2015 16:59:56 +0200 [thread overview]
Message-ID: <20150914145956.GO3383@phenom.ffwll.local> (raw)
In-Reply-To: <55F6DEE8.8090105@intel.com>
On Mon, Sep 14, 2015 at 08:21:20PM +0530, Kamble, Sagar A wrote:
> Reviewed-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
Queued for -next, thanks for the patch.
-Daniel
>
> On 9/14/2015 2:55 PM, Arun Siluvery wrote:
> >On 12/09/2015 17:52, Kamble, Sagar A wrote:
> >>
> >>
> >>On 9/8/2015 3:01 PM, Arun Siluvery wrote:
> >>>From: Robert Beckett <robert.beckett@intel.com>
> >>>
> >>>WaDisableSTUnitPowerOptimization:skl,bxt
> >>>
> >>>Signed-off-by: Robert Beckett <robert.beckett@intel.com>
> >>>Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com>
> >>>---
> >>> drivers/gpu/drm/i915/i915_reg.h | 3 +++
> >>> drivers/gpu/drm/i915/intel_ringbuffer.c | 3 +++
> >>> 2 files changed, 6 insertions(+)
> >>>
> >>>diff --git a/drivers/gpu/drm/i915/i915_reg.h
> >>>b/drivers/gpu/drm/i915/i915_reg.h
> >>>index 2c719b0..9b47dd4 100644
> >>>--- a/drivers/gpu/drm/i915/i915_reg.h
> >>>+++ b/drivers/gpu/drm/i915/i915_reg.h
> >>>@@ -6940,6 +6940,9 @@ enum skl_disp_power_wells {
> >>> #define HSW_ROW_CHICKEN3 0xe49c
> >>> #define HSW_ROW_CHICKEN3_L3_GLOBAL_ATOMICS_DISABLE (1 << 6)
> >>>+#define HALF_SLICE_CHICKEN2 0xe180
> >>>+#define GEN8_ST_PO_DISABLE (1<<13)
> >>Can we name this as GEN9_STUNIT_PO_DISABLE, since this does not apply on
> >>GEN8?
> >
> >According to the spec this bit is applicable for BDW also so Gen8 should
> >be ok.
> >
> >regards
> >Arun
> >
> >>With that: Reviewed-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
> >>>+
> >>> #define HALF_SLICE_CHICKEN3 0xe184
> >>> #define HSW_SAMPLE_C_PERFORMANCE (1<<9)
> >>> #define GEN8_CENTROID_PIXEL_OPT_DIS (1<<8)
> >>>diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c
> >>>b/drivers/gpu/drm/i915/intel_ringbuffer.c
> >>>index 0e1ed0b..028c099 100644
> >>>--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
> >>>+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
> >>>@@ -990,6 +990,9 @@ static int gen9_init_workarounds(struct
> >>>intel_engine_cs *ring)
> >>> GEN8_SAMPLER_POWER_BYPASS_DIS);
> >>> }
> >>>+ /* WaDisableSTUnitPowerOptimization:skl,bxt */
> >>>+ WA_SET_BIT_MASKED(HALF_SLICE_CHICKEN2, GEN8_ST_PO_DISABLE);
> >>>+
> >>> return 0;
> >>> }
> >>
> >>
> >
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-14 14:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 9:31 [PATCH 1/6] drm/i915/gen9: Add WaDisableSamplerPowerBypassForSOPingPong Arun Siluvery
2015-09-08 9:31 ` [PATCH 2/6] drm/i915/bxt: Add WaSetClckGatingDisableMedia Arun Siluvery
2015-09-12 16:03 ` Kamble, Sagar A
2015-09-08 9:31 ` [PATCH 3/6] drm/i915/gen9: Update WaDisableSDEUnitClockGating Arun Siluvery
2015-09-08 9:31 ` [PATCH 4/6] drm/i915/bxt: Update WaSetHDCunitClckGatingDisable Arun Siluvery
2015-09-08 9:31 ` [PATCH 5/6] drm/i915/gen9: WA ST Unit Power Optimization Disable Arun Siluvery
2015-09-12 16:52 ` Kamble, Sagar A
2015-09-14 9:25 ` Arun Siluvery
2015-09-14 14:51 ` Kamble, Sagar A
2015-09-14 14:59 ` Daniel Vetter [this message]
2015-09-08 9:31 ` [PATCH 6/6] drm/i915/gen9: Add WaDisableMinuteIaClockGating Arun Siluvery
2015-09-08 10:14 ` Kamble, Sagar A
2015-09-08 10:19 ` Kamble, Sagar A
2015-09-12 17:56 ` Kamble, Sagar A
2015-09-14 8:49 ` Daniel Vetter
2015-09-12 15:39 ` [PATCH 1/6] drm/i915/gen9: Add WaDisableSamplerPowerBypassForSOPingPong Kamble, Sagar A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914145956.GO3383@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@intel.com \
--cc=sagar.a.kamble@intel.com \
--cc=shashidhar.hiremath@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox