From: Daniel Vetter <daniel@ffwll.ch>
To: Thomas Wood <thomas.wood@intel.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t v2] scripts: add quick-testlist.py
Date: Wed, 23 Sep 2015 14:33:38 +0200 [thread overview]
Message-ID: <20150923123338.GN3383@phenom.ffwll.local> (raw)
In-Reply-To: <CANkqdn3bRZVuxt43CZtu8oi29yCtnWLfFm=hKeM8her=zoNaRg@mail.gmail.com>
On Thu, Sep 17, 2015 at 04:47:06PM +0100, Thomas Wood wrote:
> On 17 September 2015 at 13:43, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > On Thu, Sep 17, 2015 at 01:16:18PM +0100, Thomas Wood wrote:
> >> On 17 September 2015 at 13:09, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >> > On Thu, Sep 17, 2015 at 12:42:44PM +0100, Thomas Wood wrote:
> >> >> Add a script to take a piglit results file and create a list of tests
> >> >> that ran in under 60 seconds. This list can be used by the --test-list
> >> >> option of piglit.
> >> >
> >> > And passed?
> >>
> >> Any status except "incomplete", which normally means a reboot was
> >> required. It might also be worth noting that tests skipped on one
> >> platform may not skip on another, so the output only really applies to
> >> the platform the results were initially produced on.
> >
> > My point is that the timing can only be expected to be consistent for a
> > pass. A failure may be quick, but success may take a few hours.
>
> I think including failed tests depends on whether the "quick" run
> should be able to detect fixes from previous runs. Perhaps an option
> to exclude anything other than successful tests might be useful. There
> is also the timeout mechanism in piglit/igt that will prevent any test
> from running for more than 10 minutes.
Yeah, for the fast run we also need to reduce the piglit timeout to 60s
(and kill anything that timed out ofc too). Otherwise there's indeed a gap
where a testcase that takes too long could sneak in.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-23 12:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 16:07 [PATCH i-g-t] scripts: add quick-testlist.py Thomas Wood
2015-09-17 11:42 ` [PATCH i-g-t v2] " Thomas Wood
2015-09-17 12:09 ` Chris Wilson
2015-09-17 12:16 ` Thomas Wood
2015-09-17 12:43 ` Chris Wilson
2015-09-17 14:01 ` Feceoru, Gabriel
2015-09-17 15:55 ` Thomas Wood
2015-09-17 15:47 ` Thomas Wood
2015-09-23 12:33 ` Daniel Vetter [this message]
[not found] ` <1442490164-16728-1-git-send-email-thomas.wood-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-09-23 12:34 ` [Intel-gfx] " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150923123338.GN3383@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=thomas.wood@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox