From: Daniel Vetter <daniel@ffwll.ch>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: fixup runtime PM handling v2
Date: Mon, 28 Sep 2015 10:21:26 +0200 [thread overview]
Message-ID: <20150928082126.GR3383@phenom.ffwll.local> (raw)
In-Reply-To: <8158408.fmHbZlM6G4@vostro.rjw.lan>
On Thu, Sep 24, 2015 at 09:14:15PM +0200, Rafael J. Wysocki wrote:
> On Thursday, September 24, 2015 08:40:28 AM Jesse Barnes wrote:
> > Forgot to cc Rafael.
> >
> > On 09/23/2015 02:37 PM, Jesse Barnes wrote:
> > > According to the PCI docs and Rafael, we don't need to be doing explicit
> > > enables and disables in our init and teardown routines, as they're taken
> > > care of by the PCI core. So drop the pm_runtime_disable() at teardown
> > > and pm_runtime_set_active() at init.
> > >
> > > This fixes one failure of the basic-pci-d3-state test on my BYT.
> > >
> > > v2: drop extra get_noresume() and put_noidle() (Rafael)
> > >
> > > Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> > > ---
> > > drivers/gpu/drm/i915/intel_runtime_pm.c | 3 ---
> > > 1 file changed, 3 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
> > > index 85c35fd..824e7b0 100644
> > > --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> > > +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> > > @@ -1822,7 +1822,6 @@ static void intel_runtime_pm_disable(struct drm_i915_private *dev_priv)
> > >
> > > /* Make sure we're not suspended first. */
> > > pm_runtime_get_sync(device);
> > > - pm_runtime_disable(device);
> > > }
> > >
> > > /**
> > > @@ -2114,8 +2113,6 @@ void intel_runtime_pm_enable(struct drm_i915_private *dev_priv)
> > > if (!HAS_RUNTIME_PM(dev))
> > > return;
> > >
> > > - pm_runtime_set_active(device);
> > > -
> > > /*
> > > * RPM depends on RC6 to save restore the GT HW context, so make RC6 a
> > > * requirement.
> > >
> >
>
> Looks good to me, thanks!
Queued for -next, thanks for the patch.
-Daniel
>
> Rafael
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-09-28 8:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 21:23 [PATCH] drm/i915: use correct runtime get/put calls at init/teardown Jesse Barnes
2015-09-17 21:40 ` Paulo Zanoni
2015-09-17 21:59 ` Jesse Barnes
2015-09-18 1:01 ` Rafael J. Wysocki
2015-09-18 1:21 ` Rafael J. Wysocki
2015-09-23 21:37 ` [PATCH] drm/i915: fixup runtime PM handling v2 Jesse Barnes
2015-09-24 15:40 ` Jesse Barnes
2015-09-24 19:14 ` Rafael J. Wysocki
2015-09-28 8:21 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150928082126.GR3383@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox