From: Daniel Vetter <daniel@ffwll.ch>
To: Francisco Jerez <currojerez@riseup.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/6] drm/i915: Don't warn if the workaround list is empty.
Date: Wed, 7 Oct 2015 16:37:40 +0200 [thread overview]
Message-ID: <20151007143740.GQ3383@phenom.ffwll.local> (raw)
In-Reply-To: <1444218245-8430-2-git-send-email-currojerez@riseup.net>
On Wed, Oct 07, 2015 at 02:44:01PM +0300, Francisco Jerez wrote:
> It's not an error for the workaround list to be empty if no
> workarounds are needed. This will avoid spamming the logs
> unnecessarily on Gen6 after the workaround list is hooked up on
> pre-Gen8 hardware by the following commits.
>
> Signed-off-by: Francisco Jerez <currojerez@riseup.net>
I think the idea of this was to not forget this when bringing up new
platforms. I think we wrestle workarounds often enough to have a low risk
for that ;-)
Queued for -next, thanks for the patch.
-Daniel
> ---
> drivers/gpu/drm/i915/intel_ringbuffer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
> index 54ca344..3373516 100644
> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
> @@ -717,7 +717,7 @@ static int intel_ring_workarounds_emit(struct drm_i915_gem_request *req)
> struct drm_i915_private *dev_priv = dev->dev_private;
> struct i915_workarounds *w = &dev_priv->workarounds;
>
> - if (WARN_ON_ONCE(w->count == 0))
> + if (w->count == 0)
> return 0;
>
> ring->gpu_caches_dirty = true;
> --
> 2.5.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-10-07 14:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 11:44 [PATCH 1/6] drm/i915: Implement L3 partitioning set-up from the workaround list Francisco Jerez
2015-10-07 11:44 ` [PATCH 2/6] drm/i915: Don't warn if the workaround list is empty Francisco Jerez
2015-10-07 14:37 ` Daniel Vetter [this message]
2015-10-07 11:44 ` [PATCH 3/6] drm/i915: Hook up ring workaround writes at context creation time on Gen6-7 Francisco Jerez
2015-10-07 14:38 ` Daniel Vetter
2015-10-07 11:44 ` [PATCH 4/6] drm/i915: Program the L3 configuration to hardware defaults on context init Francisco Jerez
2015-10-07 11:44 ` [PATCH 5/6] drm/i915/hsw: Move L3 atomics workaround to the workaround list Francisco Jerez
2015-10-07 11:44 ` [PATCH 6/6] drm/i915/vlv: Remove WaIncreaseL3CreditsForVLVB0 from init_clock_gating Francisco Jerez
2015-10-07 12:42 ` [PATCH 1/6] drm/i915: Implement L3 partitioning set-up from the workaround list Chris Wilson
2015-10-07 13:30 ` Francisco Jerez
2015-10-08 9:17 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151007143740.GQ3383@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=currojerez@riseup.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox