public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, intel-gfx@lists.freedesktop.org,
	David Henningsson <david.henningsson@canonical.com>
Subject: Re: [PATCH v2] drm/i915: Improve kernel-doc for i915_audio_component struct
Date: Tue, 13 Oct 2015 17:41:06 +0200	[thread overview]
Message-ID: <20151013154106.GN26718@phenom.ffwll.local> (raw)
In-Reply-To: <20151013153918.GM26718@phenom.ffwll.local>

On Tue, Oct 13, 2015 at 05:39:18PM +0200, Daniel Vetter wrote:
> On Tue, Oct 13, 2015 at 11:40:23AM +0200, Takashi Iwai wrote:
> > On Mon, 12 Oct 2015 10:17:51 +0200,
> > David Henningsson wrote:
> > > 
> > > 
> > > 
> > > On 2015-10-12 10:07, David Henningsson wrote:
> > > > To make kernel-doc happy, the i915_audio_component_audio_ops struct
> > > > cannot be nested.
> > > >
> > > > Signed-off-by: David Henningsson <david.henningsson@canonical.com>
> > > > ---
> > > 
> > > Changes since v1:
> > > 
> > >   * Added a notice about when pin_eld_notify is called
> > > 
> > >   * Uses new inline struct member style
> > > 
> > > Verified with "make htmldocs", looks fine to me.
> > > 
> > > Also, applies to Takashi's tree (master branch), maybe we should take it 
> > > through Takashi's tree to avoid conflicts, especially as there might be 
> > > more stuff coming that way (dp mst support from Mengdong, and perhaps 
> > > info retrieval from me).
> > 
> > I'm fine to take it, just let me know (and give acks).
> 
> There's other doc patches floating around for this, and I've already
> pulled in your branch. Soproabbyl simpler if I pull this into
> drm-intel.git

Worse, it conflicts all over with the docbook I have already. But I like
yours better, so can you please rebase and merge with what we have?

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

      reply	other threads:[~2015-10-13 15:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-12  8:07 [PATCH v2] drm/i915: Improve kernel-doc for i915_audio_component struct David Henningsson
2015-10-12  8:17 ` David Henningsson
2015-10-13  9:40   ` Takashi Iwai
2015-10-13 15:39     ` Daniel Vetter
2015-10-13 15:41       ` Daniel Vetter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151013154106.GN26718@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=alsa-devel@alsa-project.org \
    --cc=david.henningsson@canonical.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox