From: Daniel Vetter <daniel@ffwll.ch>
To: Namrta Salonie <namrta.salonie@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/4] drm/i915 : Fix to remove unnecsessary checks in postclose function.
Date: Thu, 19 Nov 2015 16:32:27 +0100 [thread overview]
Message-ID: <20151119153227.GF17050@phenom.ffwll.local> (raw)
In-Reply-To: <1447932451-9787-4-git-send-email-namrta.salonie@intel.com>
On Thu, Nov 19, 2015 at 04:57:30PM +0530, Namrta Salonie wrote:
> Found by static analysis tool.
>
> Signed-off-by: Namrta Salonie <namrta.salonie@intel.com>
Queued for -next, thanks for the patch.
-Daniel
> ---
> drivers/gpu/drm/i915/i915_dma.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
> index 2336af9..ac1bca6 100644
> --- a/drivers/gpu/drm/i915/i915_dma.c
> +++ b/drivers/gpu/drm/i915/i915_dma.c
> @@ -1269,8 +1269,6 @@ void i915_driver_postclose(struct drm_device *dev, struct drm_file *file)
> {
> struct drm_i915_file_private *file_priv = file->driver_priv;
>
> - if (file_priv && file_priv->bsd_ring)
> - file_priv->bsd_ring = NULL;
> kfree(file_priv);
> }
>
> --
> 1.7.9.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-11-19 15:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 11:27 [PATCH 0/4] Fix issues reported by static code analysis tool Namrta Salonie
2015-11-19 11:27 ` [PATCH 1/4] drm/i915: Fix for potential NULL pointer dereference at ctx access Namrta Salonie
2015-11-19 11:40 ` Chris Wilson
2015-11-19 11:27 ` [PATCH 2/4] drm/i915: Fix possible null dereference in two debugfs functions Namrta Salonie
2015-11-19 11:37 ` Chris Wilson
2015-11-26 11:02 ` [PATCH] drm/i915: Fix possible null dereference in framebuffer_info debugfs function Namrta Salonie
2015-11-26 12:43 ` Chris Wilson
2015-11-26 14:38 ` Daniel Vetter
2015-11-27 8:13 ` Namrta Salonie
2015-11-30 8:14 ` Daniel Vetter
2015-11-19 11:27 ` [PATCH 3/4] drm/i915 : Fix to remove unnecsessary checks in postclose function Namrta Salonie
2015-11-19 15:32 ` Daniel Vetter [this message]
2015-11-19 11:27 ` [PATCH 4/4] drm/i915: Fix potential NULL pointer de-reference in ggtt unbind Namrta Salonie
2015-11-19 11:39 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151119153227.GF17050@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=namrta.salonie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox