From: Daniel Vetter <daniel@ffwll.ch>
To: Daniel Stone <daniel@fooishbar.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
intel-gfx <Intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Remove incorrect warning in context cleanup
Date: Tue, 24 Nov 2015 14:59:11 +0100 [thread overview]
Message-ID: <20151124135911.GD17050@phenom.ffwll.local> (raw)
In-Reply-To: <CAPj87rNUzfvL1crSRUWAVE-UNuDF_KreaHkxM7q1XJ=qLm8mSw@mail.gmail.com>
On Tue, Nov 24, 2015 at 01:29:07PM +0000, Daniel Stone wrote:
> Hi,
>
> On 24 November 2015 at 13:27, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > On Tue, Nov 24, 2015 at 01:17:57PM +0000, Tvrtko Ursulin wrote:
> >> On 24/11/15 12:53, Chris Wilson wrote:
> >> >The WARN_ON is accurate though. The original patch fails to fix even the
> >> >limited aspect of the bug it claimed to.
> >>
> >> That is not true. It only makes it a bit more limited, and not by
> >> its fault even. Even with that it makes things a bit better, not
> >> worse.
> >
> > It makes the code worse for very limited improvement, for which we did
> > not have a publically reported bug, i.e. the impact is very small.
>
> I can get the person who reported it to me to raise a Bugzilla
> complaining about the WARN_ON if you like ...
This is about the original bug, for with the bugfix resulted in the
WARN_ON now being removed here. The underlying problem (I think, it's a
maze) is that our vma active tracking is a bit ... underwhelming.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-11-24 13:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 13:23 [PATCH] drm/i915: Remove incorrect warning in context cleanup Tvrtko Ursulin
2015-11-24 10:58 ` Daniel Vetter
2015-11-24 12:53 ` Chris Wilson
2015-11-24 13:17 ` Tvrtko Ursulin
2015-11-24 13:27 ` Chris Wilson
2015-11-24 13:29 ` Daniel Stone
2015-11-24 13:59 ` Daniel Vetter [this message]
2015-11-24 14:18 ` Daniel Stone
2015-11-24 13:56 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151124135911.GD17050@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@fooishbar.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox