Re: [PATCH v8 1/1] drm/i915/bxt: Check BIOS RC6 setup before enabling RC6

From: Daniel Vetter <daniel@ffwll.ch>
To: Tomi Sarvela <tomi.p.sarvela@intel.com>
Cc: shashidhar.hiremath@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v8 1/1] drm/i915/bxt: Check BIOS RC6 setup before enabling RC6
Date: Tue, 16 Feb 2016 16:28:43 +0100	[thread overview]
Message-ID: <20160216152843.GJ32705@phenom.ffwll.local> (raw)
In-Reply-To: <6934057.7DBV0sVPDp@fractal>

On Tue, Feb 16, 2016 at 09:52:49AM +0200, Tomi Sarvela wrote:
> On Monday 15 February 2016 18:07:47 Daniel Vetter wrote:
> > On Mon, Feb 08, 2016 at 05:08:03PM +0200, Jani Nikula wrote:
> > > On Mon, 08 Feb 2016, Imre Deak <imre.deak@intel.com> wrote:
> > > >> > Thanks for the patch, I pushed it to -dinq.
> > > >> 
> > > >> The rule is, we should wait for the CI results before pushing.
> > > > 
> > > > Yes, I forgot to wait for the result for this version of the patch,
> > > > thanks for pointing it out. As a side-note the CI result still didn't
> > > > show up, what to do in that case? Resend the patch after a day or so?
> > > 
> > > Complain to Damien and/or Tomi.
> > 
> > CI is/was down. Please don't push patches when that happens, but instead
> > wait for things to stabilize again. Yes that slows things down, but otoh
> > everytime CI is down we manage to sneak in an overlapping regression. And
> > recovering from overlapping regressions makes everything even more painful
> > than it already is.
> > 
> > Yes, some kind of CI status dashboard is on the wishlist.
> 
> Well, CI wasn't down, it's just that there wasn't stable drm-intel-nightly to 
> apply patches on. There could be something CI could do when tree is burning, 
> and trying patches on *some* old version might not be the best choice, 
> especially when patches might try to fix the breakage. Ideas welcome.
> 
> I'm halting the Patchwork processing when in above situation. This means that 
> the non-tested Patchwork patchsets will be tested when the tree is in 
> approximately good condition. Resending doesn't change anything.
> 
> My opinion is that as Patchwork is heavily dependent on drm-intel-nightly, 
> this is probably how it should go, but automatically, without my intervention.
> 
> What kind of status dashboard would be good? As mentioned, CI itself was all 
> good and well, and status board would reflect that.

Well status board should also include status of patchwork jobs, and if
they're down why exactly ("drm-intel-nightly on fire"). So yeah I don't
expect that the status board will show "CI is down" at all ever (or at
least I hope), but communicating why patches aren't being tested would be
good. Later on we could also put up some kind of queue, so that people
know how long it'll take when there's a backlog for CI to get around to
their patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx