From: Daniel Vetter <daniel@ffwll.ch>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Intel graphics driver community testing & development
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/3] drm/i915/gtt: Reference mappable_end variable from pointer
Date: Mon, 21 Mar 2016 10:35:08 +0100 [thread overview]
Message-ID: <20160321093508.GJ28483@phenom.ffwll.local> (raw)
In-Reply-To: <1458291243.23824.1.camel@linux.intel.com>
On Fri, Mar 18, 2016 at 10:54:03AM +0200, Joonas Lahtinen wrote:
> On pe, 2016-03-18 at 08:21 +0000, Chris Wilson wrote:
> > On Fri, Mar 18, 2016 at 09:53:08AM +0200, Joonas Lahtinen wrote:
> > >
> > > Reference variable value from pointer, not assumed pointer destination.
> > >
> > > Since:
> > >
> > > commit c44ef60e437019b8ca1dab8b4d2e8761fd4ce1e9
> > > Author: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> > > Date: Thu Jun 25 18:35:05 2015 +0300
> > >
> > > drm/i915/gtt: Allow >= 4GB sizes for vm.
> > >
> > > Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> > > Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > That reminds, could you pull
> >
> > https://cgit.freedesktop.org/~ickle/linux-2.6/commit/?h=breadcrumbs&id=8ecc77b5864d4911e9fb9b92be8b2e98c3f2261f
> > [drm/i915: Codify our assumption that the Global GTT is <= 4GiB]
> >
> > into this series?
>
> Done, sent series v2 with one typo fix and that patch rebased (and
> tweaked 1ull -> 1ULL).
>
> So if somebody would review the new patch, we're good to merge.
Patch is wrong Chris, you can review it, and then push the entire pile
Congrats to volunteering ;-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-03-21 9:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 7:53 [PATCH 1/3] drm/i915/gtt: Reference mappable_end variable from pointer Joonas Lahtinen
2016-03-18 7:53 ` [PATCH 2/3] drm/i915: Rename dev_priv->gtt to dev_priv->ggtt Joonas Lahtinen
2016-03-18 8:16 ` Chris Wilson
2016-03-18 7:53 ` [PATCH 3/3] drm/i915/gtt: Clean up GGTT probing code Joonas Lahtinen
2016-03-18 8:19 ` Chris Wilson
2016-03-18 8:21 ` [PATCH 1/3] drm/i915/gtt: Reference mappable_end variable from pointer Chris Wilson
2016-03-18 8:54 ` Joonas Lahtinen
2016-03-21 9:35 ` Daniel Vetter [this message]
2016-03-21 9:39 ` Chris Wilson
2016-03-21 9:41 ` Daniel Vetter
2016-03-18 11:11 ` ✗ Fi.CI.BAT: warning for series starting with [1/3] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160321093508.GJ28483@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox