From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Arun Siluvery <arun.siluvery@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Correct stepping check for WaRsDisableCoarsePowerGating
Date: Fri, 1 Apr 2016 20:02:05 +0300 [thread overview]
Message-ID: <20160401170205.GV4329@intel.com> (raw)
In-Reply-To: <1459529017-35086-1-git-send-email-arun.siluvery@linux.intel.com>
On Fri, Apr 01, 2016 at 05:43:37PM +0100, Arun Siluvery wrote:
> This WA is applied in two different places for SKL GT3, GT4 until
> E0. Previously we were applying until F0 at one place.
>
> A macro was introduced in the below commit to replace both usages but now
> we apply this WA until F0 in both places, this patch correct this.
>
> commit 06e668ac91c93eb10bd21dfcc8891493722db29a
> Author: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Date: Wed Dec 16 19:18:37 2015 +0200
>
> drm/i915: Apply broader WaRsDisableCoarsePowerGating for guc also
So here you're essentially reverting
commit 344df9809f45 ("drm/i915/skl: Disable coarse power gating up until F0")
without any justification. Why is that the right thing to do?
>
> Cc: Sagar Arun Kamble <sagar.a.kamble@intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 10fc362..281f453 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -2637,7 +2637,7 @@ struct drm_i915_cmd_table {
> /* WaRsDisableCoarsePowerGating:skl,bxt */
> #define NEEDS_WaRsDisableCoarsePowerGating(dev) (IS_BXT_REVID(dev, 0, BXT_REVID_A1) || \
> ((IS_SKL_GT3(dev) || IS_SKL_GT4(dev)) && \
> - IS_SKL_REVID(dev, 0, SKL_REVID_F0)))
> + IS_SKL_REVID(dev, 0, SKL_REVID_E0)))
> /*
> * dp aux and gmbus irq on gen4 seems to be able to generate legacy interrupts
> * even when in MSI mode. This results in spurious interrupt warnings if the
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-01 17:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 16:43 [PATCH] drm/i915: Correct stepping check for WaRsDisableCoarsePowerGating Arun Siluvery
2016-04-01 17:02 ` Ville Syrjälä [this message]
2016-04-01 17:09 ` Arun Siluvery
2016-04-02 7:00 ` ✓ Fi.CI.BAT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160401170205.GV4329@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=arun.siluvery@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox