From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Marius Vlad <marius.c.vlad@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] lib/igt_kms: Fix atomic plane commit when fb_id is 0.
Date: Mon, 4 Apr 2016 19:05:47 +0300 [thread overview]
Message-ID: <20160404160547.GJ4329@intel.com> (raw)
In-Reply-To: <1459784845-13517-1-git-send-email-marius.c.vlad@intel.com>
On Mon, Apr 04, 2016 at 06:47:25PM +0300, Marius Vlad wrote:
> igt_atomic_prepare_plane_commit() assumes that the framebuffer is always
> set-up.
>
> Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
> ---
> lib/igt_kms.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 82257a6..30c5b7e 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -1585,7 +1585,7 @@ igt_atomic_prepare_plane_commit(igt_plane_t *plane, igt_output_t *output,
> igt_atomic_populate_plane_req(req, plane, IGT_PLANE_FB_ID, fb_id);
> }
>
> - if (plane->position_changed || plane->size_changed) {
> + if ((plane->position_changed || plane->size_changed) && fb_id != 0) {
> uint32_t src_x = IGT_FIXED(plane->fb->src_x, 0); /* src_x */
> uint32_t src_y = IGT_FIXED(plane->fb->src_y, 0); /* src_y */
> uint32_t src_w = IGT_FIXED(plane->fb->src_w, 0); /* src_w */
Someone should really move the src coordinates from the fb into the plane.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-04 16:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 15:47 [PATCH i-g-t] lib/igt_kms: Fix atomic plane commit when fb_id is 0 Marius Vlad
2016-04-04 15:53 ` Lionel Landwerlin
2016-04-04 16:05 ` Ville Syrjälä [this message]
2016-04-05 8:46 ` Maarten Lankhorst
2016-04-05 10:29 ` Marius Vlad
2016-04-05 10:58 ` Maarten Lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160404160547.GJ4329@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=marius.c.vlad@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox