From: Daniel Vetter <daniel@ffwll.ch>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: Micah Fedke <micah.fedke@collabora.com>,
Intel GFX discussion <intel-gfx@lists.freedesktop.org>,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
Daniel Stone <daniels@collabora.com>,
Emil Velikov <emil.velikov@collabora.com>
Subject: Re: [i-g-t PATCH v1 0/2] Avoid calling DRM_IOCTL_I915_GET_PIPE_FROM_CRTC_ID on !i915
Date: Wed, 20 Apr 2016 16:14:48 +0200 [thread overview]
Message-ID: <20160420141448.GK2510@phenom.ffwll.local> (raw)
In-Reply-To: <1461066028-30499-1-git-send-email-tomeu.vizoso@collabora.com>
On Tue, Apr 19, 2016 at 01:40:26PM +0200, Tomeu Vizoso wrote:
> Hi,
>
> following Daniel's comments on a previous series that completely removed
> usage of DRM_IOCTL_I915_GET_PIPE_FROM_CRTC_ID, I'm sending this one that
> removes it only on codepaths that can be run on drivers other than i915.
>
> It does so by using the already-available crtc indexes instead of
> querying for the pipe number (which should return the same value).
Problem is a bit that KMS ids in general are really hard to tell apart. In
the kernel we started to have proper names for all of them, and let
drivers set those on a per-chip basis even, to make sure they match the hw
specs.
I do think keeping the pipe id around is somewhat useful, since for most
hw it's a valid concept to enumerate crtcs like that.
-Daniel
>
> Thanks,
>
> Tomeu
>
>
> Tomeu Vizoso (2):
> lib: Remove superfluous kmstest_connector_config.pipe
> tests/kms_setmode: Remove superfluous call to
> kmstest_get_pipe_from_crtc_id
>
> lib/igt_kms.c | 24 +++++++++++-------------
> lib/igt_kms.h | 1 -
> tests/kms_crtc_background_color.c | 2 +-
> tests/kms_flip.c | 10 +++++-----
> tests/kms_flip_tiling.c | 2 +-
> tests/kms_panel_fitting.c | 2 +-
> tests/kms_plane_scaling.c | 2 +-
> tests/kms_render.c | 2 +-
> tests/kms_setmode.c | 5 +----
> tests/testdisplay.c | 1 -
> 10 files changed, 22 insertions(+), 29 deletions(-)
>
> --
> 2.5.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-04-20 14:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 11:40 [i-g-t PATCH v1 0/2] Avoid calling DRM_IOCTL_I915_GET_PIPE_FROM_CRTC_ID on !i915 Tomeu Vizoso
2016-04-19 11:40 ` [i-g-t PATCH v1 1/2] lib: Remove superfluous kmstest_connector_config.pipe Tomeu Vizoso
2016-04-19 11:40 ` [i-g-t PATCH v1 2/2] tests/kms_setmode: Remove superfluous call to kmstest_get_pipe_from_crtc_id Tomeu Vizoso
2016-04-20 14:14 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160420141448.GK2510@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniels@collabora.com \
--cc=emil.velikov@collabora.com \
--cc=gustavo.padovan@collabora.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=micah.fedke@collabora.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox