From: Daniel Vetter <daniel@ffwll.ch>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel graphics driver community testing & development
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH maintainer-tools 2/2] dim: Refuse to commit patches that modify files outside of i915
Date: Thu, 28 Apr 2016 16:04:32 +0200 [thread overview]
Message-ID: <20160428130025.GA5784@phenom.ffwll.local> (raw)
In-Reply-To: <1461843140-19122-2-git-send-email-joonas.lahtinen@linux.intel.com>
On Thu, Apr 28, 2016 at 02:32:20PM +0300, Joonas Lahtinen wrote:
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> ---
> dim | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/dim b/dim
> index dbcb7d9..1c258be 100755
> --- a/dim
> +++ b/dim
> @@ -691,6 +691,11 @@ function checkpatch_commit
> if test "$bug_lines" -eq 1; then
> warn_or_fail "New BUG macro added"
> fi
> +
> + local non_i915_files=$(git diff-tree --no-commit-id --name-only -r HEAD | grep -v "^\(drivers/gpu/drm/i915/\|include/drm/i915\|include/uapi/drm/i915\)")
> + if [ -n "$non_i915_files" ]; then
> + warn_or_fail "The following files are outside of i915 maintenance scope:\n$non_i915_files\n\nConfirm you have appropriate Acked-by and Reviewed-by for above files"
> + fi
> }
You need to restrict this to the drm-intel-next-queued branch. And I think
asking the user instead of warn_or_fail would be nice, but not directly
needed. Otherwise lgtm for both patches.
-Daniel
>
> # turn $1 in to a git commit range
> --
> 2.5.5
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-04-28 14:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 11:32 [PATCH maintainer-tools 1/2] dim: Use -e on warn_or_fail to allow fo newlines Joonas Lahtinen
2016-04-28 11:32 ` [PATCH maintainer-tools 2/2] dim: Refuse to commit patches that modify files outside of i915 Joonas Lahtinen
2016-04-28 12:47 ` Jani Nikula
2016-04-28 14:04 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160428130025.GA5784@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox