From: Marius Vlad <marius.c.vlad@intel.com>
To: robert.foss@collabora.com
Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org,
daniel.stone@collabora.com
Subject: Re: [PATCH i-g-t v5 6/6] kms_panel_fitting: Enable connectors with "scaling mode" property set.
Date: Tue, 3 May 2016 16:31:19 +0300 [thread overview]
Message-ID: <20160503133119.GA16187@mcvlad-wk.rb.intel.com> (raw)
In-Reply-To: <1461851124-27256-7-git-send-email-robert.foss@collabora.com>
[-- Attachment #1.1: Type: text/plain, Size: 1678 bytes --]
This doesn't apply cleanly, the patch from Jani from was not applied, so
is still using igt_require() for testing the connector type. Diff
against master.
On Thu, Apr 28, 2016 at 09:45:24AM -0400, robert.foss@collabora.com wrote:
> From: Robert Foss <robert.foss@collabora.com>
>
> Enable testing on all connectors that have the "scaling mode"
> property set.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93012
> Signed-off-by: Robert Foss <robert.foss@collabora.com>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> tests/kms_panel_fitting.c | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
> index 272a531..b796c68 100644
> --- a/tests/kms_panel_fitting.c
> +++ b/tests/kms_panel_fitting.c
> @@ -139,9 +139,18 @@ static void test_panel_fitting(data_t *d)
>
> for_each_connected_output(display, output) {
> drmModeModeInfo *mode, native_mode;
> -
> - if (output->config.connector->connector_type !=
> - DRM_MODE_CONNECTOR_eDP)
> + bool scaling_mode_set;
> +
> + scaling_mode_set = kmstest_get_property(d->drm_fd,
> + output->config.connector->connector_id,
> + DRM_MODE_OBJECT_CONNECTOR,
> + "scaling mode",
> + NULL,
> + NULL,
> + NULL);
> +
> + /* Check that the "scaling mode" property has been set. */
> + if (!scaling_mode_set)
> continue;
>
> pipe = output->config.pipe;
> --
> 2.5.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-05-03 13:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 13:45 [PATCH i-g-t v5 0/6] Improve kms_panel_fitting robert.foss
2016-04-28 13:45 ` [PATCH i-g-t v5 1/6] kms_panel_fitting: Remove un-read variable robert.foss
2016-04-28 13:45 ` [PATCH i-g-t v5 2/6] kms_panel_fitting: Remove un-read variable pipe_crc robert.foss
2016-04-28 13:45 ` [PATCH i-g-t v5 3/6] kms_panel_fitting: Remove un-used variable robert.foss
2016-04-28 13:45 ` [PATCH i-g-t v5 4/6] kms_panel_fitting: Switched DRM format to a hardware agnostic alternative robert.foss
2016-04-28 13:45 ` [PATCH i-g-t v5 5/6] kms_panel_fitting: Enabled test on non-Intel hardware robert.foss
2016-04-28 13:45 ` [PATCH i-g-t v5 6/6] kms_panel_fitting: Enable connectors with "scaling mode" property set robert.foss
2016-05-03 13:31 ` Marius Vlad [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160503133119.GA16187@mcvlad-wk.rb.intel.com \
--to=marius.c.vlad@intel.com \
--cc=daniel.stone@collabora.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=robert.foss@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox