From: Daniel Vetter <daniel@ffwll.ch>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm/i915: Bail out of pipe config compute loop on LPT
Date: Wed, 4 May 2016 17:16:15 +0200 [thread overview]
Message-ID: <20160504151615.GC1286@phenom.ffwll.local> (raw)
In-Reply-To: <0a1d1767-68eb-a923-63ce-45e8dbd09eda@linux.intel.com>
On Tue, May 03, 2016 at 11:29:21AM +0200, Maarten Lankhorst wrote:
> Op 03-05-16 om 10:33 schreef Daniel Vetter:
> > LPT is pch, so might run into the fdi bandwidth constraint (especially
> > since it has only 2 lanes). But right now we just force pipe_bpp back
> > to 24, resulting in a nice loop (which we bail out with a loud
> > WARN_ON). Fix this.
> >
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=93477
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_crt.c | 8 +++++++-
> > 1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
> > index a2a31fd01d1d..3fbb6fc66451 100644
> > --- a/drivers/gpu/drm/i915/intel_crt.c
> > +++ b/drivers/gpu/drm/i915/intel_crt.c
> > @@ -261,8 +261,14 @@ static bool intel_crt_compute_config(struct intel_encoder *encoder,
> > pipe_config->has_pch_encoder = true;
> >
> > /* LPT FDI RX only supports 8bpc. */
> > - if (HAS_PCH_LPT(dev))
> > + if (HAS_PCH_LPT(dev)) {
> > + if (pipe_config->bw_constrained && pipe_config->pipe_bpp < 24) {
> > + DRM_DEBUG_KMS("LPT only supports 24bpp\n");
> > + return false;
> > + }
> > +
> > pipe_config->pipe_bpp = 24;
> > + }
> >
> > /* FDI must always be 2.7 GHz */
> > if (HAS_DDI(dev))
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Applied the patch to dinq.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-05-04 15:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 8:33 [PATCH] drm/i915: Bail out of pipe config compute loop on LPT Daniel Vetter
2016-05-03 9:15 ` Chris Wilson
2016-05-03 9:25 ` ✗ Fi.CI.BAT: warning for " Patchwork
2016-05-03 9:33 ` Chris Wilson
2016-05-04 15:14 ` Daniel Vetter
2016-05-03 9:29 ` [PATCH] " Maarten Lankhorst
2016-05-04 15:16 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160504151615.GC1286@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox