Re: [PATCH] x86: Silence 32bit compiler warning in intel_graphics_stolen()

From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	intel-gfx@lists.freedesktop.org, Ingo Molnar <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Mika Kuoppala <mika.kuoppala@intel.com>
Subject: Re: [PATCH] x86: Silence 32bit compiler warning in intel_graphics_stolen()
Date: Fri, 6 May 2016 13:57:38 +0300	[thread overview]
Message-ID: <20160506105738.GX4329@intel.com> (raw)
In-Reply-To: <1462464917-10872-1-git-send-email-chris@chris-wilson.co.uk>

On Thu, May 05, 2016 at 05:15:17PM +0100, Chris Wilson wrote:
> arch/x86/kernel/early-quirks.c: In function ‘intel_graphics_stolen’:
> arch/x86/kernel/early-quirks.c:539:9: warning: format ‘%llx’ expects
> argument of type ‘long long unsigned int’, but argument 2 has type ‘phys_addr_t’ [-Wformat=]
>          "0x%llx-0x%llx\n", base, base + size - 1);
>          ^
> arch/x86/kernel/early-quirks.c:539:9: warning: format ‘%llx’ expects
> argument of type ‘long long unsigned int’, but argument 3 has type ‘phys_addr_t’ [-Wformat=]

This also makes the actual printk output crap. On my non-PAE machine
I saw somehting resembling this:
Reserving Intel graphics memory at 0x37ffffff3ffffffff-0x200000000

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> 
> Fixes: ee0629cfd3c16 (drm/i915: Function per early graphics quirk)
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> ---
>  arch/x86/kernel/early-quirks.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> index d2f75b4..068ab3f 100644
> --- a/arch/x86/kernel/early-quirks.c
> +++ b/arch/x86/kernel/early-quirks.c
> @@ -535,8 +535,8 @@ intel_graphics_stolen(int num, int slot, int func,
>  	if (!size || !base)
>  		return;
>  
> -	printk(KERN_INFO "Reserving Intel graphics stolen memory at "
> -	       "0x%llx-0x%llx\n", base, base + size - 1);
> +	printk(KERN_INFO "Reserving Intel graphics memory at 0x%llx-0x%llx\n",
> +	       (long long)base, (long long)(base + size - 1));
>  
>  	/* Mark this space as reserved */
>  	e820_add_region(base, size, E820_RESERVED);
> -- 
> 2.8.1

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx