From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Ander Conselvan De Oliveira <conselvan2@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: s/DPPL/DPLL/ for SKL DPLLs
Date: Thu, 12 May 2016 14:32:06 +0300 [thread overview]
Message-ID: <20160512113206.GI4329@intel.com> (raw)
In-Reply-To: <1463037345.2668.2.camel@gmail.com>
On Thu, May 12, 2016 at 10:15:45AM +0300, Ander Conselvan De Oliveira wrote:
> On Wed, 2016-05-11 at 22:04 +0300, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > SKL DPLLs shouldn't be called DPPLs.
>
> I really didn't notice that typo. Thanks for fixing.
>
> Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>
Thanks. Pushed to dinq.
>
> >
> > Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> > Fixes: 2edd6443e3d0 ("drm/i915: Use a table to initilize shared dplls")
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_dpll_mgr.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c
> > b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> > index 639bf0209c15..3ac705936b04 100644
> > --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
> > +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> > @@ -1702,9 +1702,9 @@ static const struct intel_dpll_mgr hsw_pll_mgr = {
> >
> > static const struct dpll_info skl_plls[] = {
> > { "DPLL 0", DPLL_ID_SKL_DPLL0, &skl_ddi_dpll0_funcs,
> > INTEL_DPLL_ALWAYS_ON },
> > - { "DPPL 1", DPLL_ID_SKL_DPLL1, &skl_ddi_pll_funcs, 0 },
> > - { "DPPL 2", DPLL_ID_SKL_DPLL2, &skl_ddi_pll_funcs, 0 },
> > - { "DPPL 3", DPLL_ID_SKL_DPLL3, &skl_ddi_pll_funcs, 0 },
> > + { "DPLL 1", DPLL_ID_SKL_DPLL1, &skl_ddi_pll_funcs, 0 },
> > + { "DPLL 2", DPLL_ID_SKL_DPLL2, &skl_ddi_pll_funcs, 0 },
> > + { "DPLL 3", DPLL_ID_SKL_DPLL3, &skl_ddi_pll_funcs, 0 },
> > { NULL, -1, NULL, },
> > };
> >
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-05-12 11:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 19:04 [PATCH] drm/i915: s/DPPL/DPLL/ for SKL DPLLs ville.syrjala
2016-05-11 19:55 ` ✗ Ro.CI.BAT: failure for " Patchwork
2016-05-12 11:24 ` Ville Syrjälä
2016-05-12 7:15 ` [PATCH] " Ander Conselvan De Oliveira
2016-05-12 11:32 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160512113206.GI4329@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=conselvan2@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox