From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: libin.yang@linux.intel.com
Cc: tiwai@suse.de, daniel.vetter@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3 2/3] drm/i915: set proper N/MCTS on more platforms
Date: Thu, 4 Aug 2016 11:54:09 +0300 [thread overview]
Message-ID: <20160804085409.GB4329@intel.com> (raw)
In-Reply-To: <1470297484-82178-2-git-send-email-libin.yang@linux.intel.com>
On Thu, Aug 04, 2016 at 03:58:03PM +0800, libin.yang@linux.intel.com wrote:
> From: Libin Yang <libin.yang@linux.intel.com>
>
> This patch applies setting proper N/M, N/CTS on more platforms.
>
> Signed-off-by: Libin Yang <libin.yang@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Not that I particularly like this special casing of platforms. We should
really try to unify this across the board, and I thought we already
agreed that that was going to happen?
> ---
> drivers/gpu/drm/i915/intel_audio.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> index 04e7358..7aa0203 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -732,11 +732,7 @@ static int i915_audio_component_sync_audio_rate(struct device *dev,
> int n;
> int err = 0;
>
> - /* HSW, BDW, SKL, KBL need this fix */
> - if (!IS_SKYLAKE(dev_priv) &&
> - !IS_KABYLAKE(dev_priv) &&
> - !IS_BROADWELL(dev_priv) &&
> - !IS_HASWELL(dev_priv))
> + if (!HAS_DDI(dev_priv))
> return 0;
>
> mutex_lock(&dev_priv->av_mutex);
> --
> 1.9.1
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-08-04 8:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 7:58 [PATCH v3 1/3] drm/i915: set proper N/M in modeset libin.yang
2016-08-04 7:58 ` [PATCH v3 2/3] drm/i915: set proper N/MCTS on more platforms libin.yang
2016-08-04 8:54 ` Ville Syrjälä [this message]
2016-08-05 5:41 ` Yang, Libin
2016-08-04 7:58 ` [PATCH v3 3/3] drm/i915: HDMI audio gets the TMDS clock by crtc_clock libin.yang
2016-08-04 8:57 ` Ville Syrjälä
2016-08-04 8:52 ` [PATCH v3 1/3] drm/i915: set proper N/M in modeset Ville Syrjälä
2016-08-05 5:39 ` Yang, Libin
2016-08-05 5:56 ` Ville Syrjälä
2016-08-05 6:16 ` Yang, Libin
2016-08-05 6:36 ` Ville Syrjälä
2016-08-05 6:40 ` Yang, Libin
2016-08-05 7:16 ` Ville Syrjälä
2016-08-05 7:24 ` Yang, Libin
2016-08-05 8:45 ` Ville Syrjälä
2016-08-05 8:55 ` Yang, Libin
2016-08-05 10:54 ` Ville Syrjälä
2016-08-05 12:32 ` Yang, Libin
2016-08-04 9:32 ` ✗ Ro.CI.BAT: failure for series starting with [v3,1/3] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160804085409.GB4329@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=libin.yang@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox