From: Matt Roper <matthew.d.roper@intel.com>
To: Bob Paauwe <bob.j.paauwe@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] igt_kms: Use proper panning coordinates for legacy primary plane updates
Date: Thu, 4 Aug 2016 13:47:44 -0700 [thread overview]
Message-ID: <20160804204744.GS32025@intel.com> (raw)
In-Reply-To: <20160803103515.35d8bd16@bpaauwe-desk.fm.intel.com>
On Wed, Aug 03, 2016 at 10:35:15AM -0700, Bob Paauwe wrote:
> On Wed, 3 Aug 2016 09:15:41 -0700
> Matt Roper <matthew.d.roper@intel.com> wrote:
>
> > A copy/paste error resulted in us using src_x for both the x and y
> > panning coordinates; make sure we use src_y instead for the appropriate
> > parameter.
> >
> > Fixes: 0e29ce3265b ("igt_kms: Remove pan members from igt_plane, v2.")
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
>
> Reviewed-by: Bob Paauwe <bob.j.paauwe@intel.com>
Merged; thanks for the review.
Matt
>
> > ---
> > lib/igt_kms.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> > index 7d7a53c..ed91688 100644
> > --- a/lib/igt_kms.c
> > +++ b/lib/igt_kms.c
> > @@ -1937,13 +1937,13 @@ static int igt_primary_plane_commit_legacy(igt_plane_t *primary,
> > igt_output_name(output),
> > kmstest_pipe_name(pipe->pipe),
> > fb_id,
> > - primary->src_x, primary->src_x,
> > + primary->src_x, primary->src_y,
> > mode->hdisplay, mode->vdisplay);
> >
> > ret = drmModeSetCrtc(display->drm_fd,
> > crtc_id,
> > fb_id,
> > - primary->src_x, primary->src_x,
> > + primary->src_x, primary->src_y,
> > &output->id,
> > 1,
> > mode);
>
>
>
> --
> --
> Bob Paauwe
> Bob.J.Paauwe@intel.com
> IOTG / PED Software Organization
> Intel Corp. Folsom, CA
> (916) 356-6193
>
--
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-08-04 20:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 16:15 [PATCH i-g-t] igt_kms: Use proper panning coordinates for legacy primary plane updates Matt Roper
2016-08-03 17:35 ` Bob Paauwe
2016-08-04 20:47 ` Matt Roper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160804204744.GS32025@intel.com \
--to=matthew.d.roper@intel.com \
--cc=bob.j.paauwe@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox