From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH igt] igt/kms_setmode: Clear all connectors before starting the test
Date: Mon, 24 Oct 2016 13:11:49 +0300 [thread overview]
Message-ID: <20161024101149.GE4617@intel.com> (raw)
In-Reply-To: <20161024090435.GM20761@phenom.ffwll.local>
On Mon, Oct 24, 2016 at 11:04:35AM +0200, Daniel Vetter wrote:
> On Sat, Oct 22, 2016 at 09:32:41AM +0100, Chris Wilson wrote:
> > Before we start trying random combinations of connectors and CRTCs, we
> > should first ensure we have a blank slate so that if we only change a
> > subset of the CRTC we do not conflict with a residual setup on the other
> > CRTC.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> > tests/kms_setmode.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
> > index 24fb34c..df958f0 100644
> > --- a/tests/kms_setmode.c
> > +++ b/tests/kms_setmode.c
> > @@ -268,6 +268,10 @@ static void setup_crtcs(drmModeRes *resources, struct connector_config *cconf,
> > int i;
> > int encoder_usage_count[resources->count_encoders];
> >
> > + for (i = 0; i < resources->count_crtcs; i++)
> > + drmModeSetCrtc(drm_fd, resources->crtcs[i],
> > + 0, 0, 0, 0, 0, NULL);
>
> Shouldn't this be in some modeset helper library, or is kms_setmode not
> using that one?
Like kmstest_unset_all_crtcs() ?
> Especially with atomic it's much neater to just clear our
> software state (and then applying all the changes we want in one go).
>
> But it does get the job done meanwhile, so ack.
> -Daniel
> > +
> > i = 0;
> > crtc_count = 0;
> > crtc = crtcs;
> > --
> > 2.9.3
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-10-24 10:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-22 8:32 [PATCH igt] igt/kms_setmode: Clear all connectors before starting the test Chris Wilson
2016-10-24 9:04 ` Daniel Vetter
2016-10-24 9:17 ` Chris Wilson
2016-10-24 10:11 ` Ville Syrjälä [this message]
2016-10-24 10:22 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024101149.GE4617@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox