From: Sean Paul <seanpaul@chromium.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] drm/fb-helper: Automatically clean up fb_info
Date: Tue, 7 Feb 2017 10:51:24 -0500 [thread overview]
Message-ID: <20170207155124.GE15150@art_vandelay> (raw)
In-Reply-To: <20170207141050.1129-2-daniel.vetter@ffwll.ch>
On Tue, Feb 07, 2017 at 03:10:50PM +0100, Daniel Vetter wrote:
> Noticed that everyone duplicates the same logic here and we could safe
> a few lines per driver. Yay for lots of drivers to make such tiny
> refactors worth-while!
>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Sean Paul <seanpaul@chromium.org>
> Cc: Noralf Trønnes <noralf@tronnes.org>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 11 ++++-------
> drivers/gpu/drm/armada/armada_fbdev.c | 2 --
> drivers/gpu/drm/ast/ast_fb.c | 9 +++------
> drivers/gpu/drm/bochs/bochs_fbdev.c | 5 +----
> drivers/gpu/drm/cirrus/cirrus_fbdev.c | 1 -
> drivers/gpu/drm/drm_fb_cma_helper.c | 3 +--
> drivers/gpu/drm/drm_fb_helper.c | 16 ++++++++++++++--
> drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 --
> drivers/gpu/drm/gma500/framebuffer.c | 9 +++------
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | 3 +--
> drivers/gpu/drm/i915/intel_fbdev.c | 5 +----
> drivers/gpu/drm/mgag200/mgag200_fb.c | 5 +----
> drivers/gpu/drm/msm/msm_fbdev.c | 1 -
> drivers/gpu/drm/nouveau/nouveau_fbcon.c | 1 -
> drivers/gpu/drm/omapdrm/omap_fbdev.c | 4 ----
> drivers/gpu/drm/qxl/qxl_fb.c | 5 +----
> drivers/gpu/drm/radeon/radeon_fb.c | 11 ++++-------
> drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 9 +++------
> drivers/gpu/drm/tegra/fb.c | 5 +----
> drivers/gpu/drm/udl/udl_fb.c | 5 +----
> drivers/gpu/drm/virtio/virtgpu_fb.c | 5 +----
> include/drm/drm_fb_helper.h | 4 ----
> 22 files changed, 40 insertions(+), 81 deletions(-)
>
Driver changes look good. I'll echo Emil's comments about removing
drm_fb_helper_release_fbi() from drm_fb_helper.c
Sean
<snip>
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-02-07 15:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 14:10 [PATCH 1/2] drm/fb-helper: Explain unload sequence a bit better Daniel Vetter
2017-02-07 14:10 ` [PATCH 2/2] drm/fb-helper: Automatically clean up fb_info Daniel Vetter
2017-02-07 14:29 ` [PATCH] " Daniel Vetter
2017-02-07 14:38 ` Emil Velikov
2017-02-07 14:49 ` [Intel-gfx] " Chris Wilson
2017-02-07 16:09 ` Daniel Vetter
2017-02-08 0:49 ` Emil Velikov
2017-02-07 16:16 ` Daniel Vetter
2017-02-07 16:27 ` Sean Paul
2017-02-07 14:34 ` [PATCH 2/2] " Chris Wilson
2017-02-07 15:51 ` Sean Paul [this message]
2017-02-07 14:28 ` [PATCH 1/2] drm/fb-helper: Explain unload sequence a bit better Chris Wilson
2017-02-07 17:32 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/fb-helper: Explain unload sequence a bit better (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207155124.GE15150@art_vandelay \
--to=seanpaul@chromium.org \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox