From: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
To: intel-gfx@lists.freedesktop.org,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Subject: [PATCH v2 4/4] drm/i915/glk: Fix Geminilake scalers mode programming
Date: Thu, 23 Feb 2017 09:16:00 +0200 [thread overview]
Message-ID: <20170223071600.14356-5-ander.conselvan.de.oliveira@intel.com> (raw)
In-Reply-To: <20170223071600.14356-1-ander.conselvan.de.oliveira@intel.com>
Geminilake scalers can do 7x7 filtering for all supported input sizes,
so it doesn't need the "high quality" mode programming, which was
actually removed from that platform.
v2: Split dev_priv parameter change out. (Ville)
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>,
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
---
drivers/gpu/drm/i915/intel_atomic.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_atomic.c b/drivers/gpu/drm/i915/intel_atomic.c
index 58916e3..e65818e 100644
--- a/drivers/gpu/drm/i915/intel_atomic.c
+++ b/drivers/gpu/drm/i915/intel_atomic.c
@@ -247,7 +247,9 @@ int intel_atomic_setup_scalers(struct drm_i915_private *dev_priv,
}
/* set scaler mode */
- if (num_scalers_need == 1 && intel_crtc->pipe != PIPE_C) {
+ if (IS_GEMINILAKE(dev_priv)) {
+ scaler_state->scalers[*scaler_id].mode = 0;
+ } else if (num_scalers_need == 1 && intel_crtc->pipe != PIPE_C) {
/*
* when only 1 scaler is in use on either pipe A or B,
* scaler 0 operates in high quality (HQ) mode.
--
2.9.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-02-23 7:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 7:15 [PATCH v2 0/4] GLK plane/scaling fixes Ander Conselvan de Oliveira
2017-02-23 7:15 ` [PATCH v2 1/4] drm/i915/glk: Fix watermark computations for third sprite plane Ander Conselvan de Oliveira
2017-02-23 10:02 ` Ville Syrjälä
2017-02-23 12:24 ` Ander Conselvan De Oliveira
2017-02-23 13:16 ` Ville Syrjälä
2017-02-23 7:15 ` [PATCH v2 2/4] drm/i915/glk: Fix maximum scaling factor for Geminilake scalers Ander Conselvan de Oliveira
2017-02-23 10:04 ` Ville Syrjälä
2017-02-23 12:26 ` Ander Conselvan De Oliveira
2017-02-23 7:15 ` [PATCH v2 3/4] drm/i915/glk: Pass dev_priv to intel_atomic_setup_scalers() Ander Conselvan de Oliveira
2017-02-23 11:24 ` Ville Syrjälä
2017-02-23 7:16 ` Ander Conselvan de Oliveira [this message]
2017-02-23 11:30 ` [PATCH v2 4/4] drm/i915/glk: Fix Geminilake scalers mode programming Ville Syrjälä
2017-02-23 7:52 ` ✓ Fi.CI.BAT: success for GLK plane/scaling fixes (rev2) Patchwork
2017-02-23 13:25 ` Ander Conselvan De Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170223071600.14356-5-ander.conselvan.de.oliveira@intel.com \
--to=ander.conselvan.de.oliveira@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox