Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: tina.zhang@intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: [bug report] drm/i915/gvt: replace the gvt_err with gvt_vgpu_err
Date: Wed, 22 Mar 2017 14:24:02 +0300	[thread overview]
Message-ID: <20170322112402.GA17653@mwanda> (raw)

Hello Tina Zhang,

This is a semi-automatic email about new static checker warnings.

The patch 695fbc08d80f: "drm/i915/gvt: replace the gvt_err with 
gvt_vgpu_err" from Mar 10, 2017, leads to the following Smatch 
complaint:

drivers/gpu/drm/i915/gvt/kvmgt.c:1344 kvmgt_guest_exit()
	 warn: variable dereferenced before check 'info' (see line 1342)

drivers/gpu/drm/i915/gvt/kvmgt.c
  1341	{
  1342		struct intel_vgpu *vgpu = info->vgpu;
                                          ^^^^^^^^^^
Patch adds a new dereference.

  1343	
  1344		if (!info) {
                    ^^^^^
Existing check.

  1345			gvt_vgpu_err("kvmgt_guest_info invalid\n");
  1346			return false;

regards,
dan carpenter
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

                 reply	other threads:[~2017-03-22 11:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170322112402.GA17653@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=tina.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox