From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm: Fix get_property logic fumble
Date: Wed, 12 Apr 2017 17:18:38 +0200 [thread overview]
Message-ID: <20170412151838.pbobpcvecnereaa2@phenom.ffwll.local> (raw)
In-Reply-To: <20170410123701.GK6834@nuc-i3427.alporthouse.com>
On Mon, Apr 10, 2017 at 01:37:01PM +0100, Chris Wilson wrote:
> On Mon, Apr 10, 2017 at 01:54:45PM +0200, Daniel Vetter wrote:
> > Yet again I've proven that I can't negate conditions :(
> >
> > Fixes: eb8eb02ed850 ("drm: Drop modeset_lock_all from the getproperty ioctl")
>
> You also get to write the igt/kms_getproperty, starting with a
> memset(prop_values, 0xc5, foo);
> drmIoctl(GETPROPERTY);
> igt_assert(!memchr(prop_values, 0xc5, bar));
Testcase: igt/kms_properties/get_property-sanity
Thanks for reminding me to not be lazy with testing stuff we've broken!
Pushed the patch to -next-fixes.
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-04-12 15:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 11:54 [PATCH] drm: Fix get_property logic fumble Daniel Vetter
2017-04-10 12:14 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-04-10 12:37 ` [Intel-gfx] [PATCH] " Chris Wilson
2017-04-12 15:18 ` Daniel Vetter [this message]
2017-04-10 12:40 ` Maarten Lankhorst
2017-04-10 17:16 ` Sean Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170412151838.pbobpcvecnereaa2@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox