From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Intel graphics driver community testing & development
<intel-gfx@lists.freedesktop.org>,
Mika Kuoppala <mika.kuoppala@intel.com>
Subject: Re: [PATCH 2/2] drm/i915: Eliminate HAS_HW_CONTEXTS
Date: Thu, 27 Apr 2017 18:44:57 +0300 [thread overview]
Message-ID: <20170427154457.GQ30290@intel.com> (raw)
In-Reply-To: <20170427153255.GD3390@nuc-i3427.alporthouse.com>
On Thu, Apr 27, 2017 at 04:32:55PM +0100, Chris Wilson wrote:
> On Thu, Apr 27, 2017 at 05:36:55PM +0300, Ville Syrjälä wrote:
> > On Thu, Apr 27, 2017 at 04:41:33PM +0300, Joonas Lahtinen wrote:
> > > According to Chris i915_gem_sanitize was meant to reset ILK too.
> >
> > In that case drawing the line before g4x might make more sense
> > since it already has a GPU reset that doesn't clobber the display.
>
> The initial reasoning for the cutoff was anything that used contexts for
> real. We do want to extend it to everything that we can realiably reset.
> One step at a time.
This patch looked more like three steps to me. First step could have
been just removing the flag and adjusting the code to check for gen>=6.
>
> > >
> > > CCID register existed already on ILK according to the PRM (Chris
> > > verified the address to match too).
> >
> > I think it has existed since forever actually. Well, not sure about
> > gen0-1.
>
> Hmm, didn't realise that (or completely forgot). Logical contexts exist
> for gen2/3 as well. Enabling for g4x+ might be fun.
Not sure it's actually functional there. The docs seem to indicate
that there's some linkage between contexts and run lists.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-04-27 15:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 13:41 [PATCH 1/2] drm/i915: Sanitize engine context sizes Joonas Lahtinen
2017-04-27 13:41 ` [PATCH 2/2] drm/i915: Eliminate HAS_HW_CONTEXTS Joonas Lahtinen
2017-04-27 14:31 ` Chris Wilson
2017-04-27 14:36 ` Ville Syrjälä
2017-04-27 15:32 ` Chris Wilson
2017-04-27 15:44 ` Ville Syrjälä [this message]
2017-04-27 14:30 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Sanitize engine context sizes Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170427154457.GQ30290@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=mika.kuoppala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox