From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: clinton.a.taylor@intel.com
Cc: Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/glk: RGB565 planes now allow 90/270 rotation
Date: Wed, 7 Jun 2017 20:55:29 +0300 [thread overview]
Message-ID: <20170607175529.GN12629@intel.com> (raw)
In-Reply-To: <1496857525-28197-1-git-send-email-clinton.a.taylor@intel.com>
On Wed, Jun 07, 2017 at 10:45:25AM -0700, clinton.a.taylor@intel.com wrote:
> From: Clint Taylor <clinton.a.taylor@intel.com>
>
> RGB565 Pixel format planes can now be rotated at 90 and 270 degrees
"now" == since when?
>
> Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>
> ---
> drivers/gpu/drm/i915/intel_atomic_plane.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_atomic_plane.c b/drivers/gpu/drm/i915/intel_atomic_plane.c
> index 4325cb0..9a7a7ea 100644
> --- a/drivers/gpu/drm/i915/intel_atomic_plane.c
> +++ b/drivers/gpu/drm/i915/intel_atomic_plane.c
> @@ -144,19 +144,16 @@ int intel_plane_atomic_check_with_state(struct intel_crtc_state *crtc_state,
>
> /*
> * 90/270 is not allowed with RGB64 16:16:16:16,
> - * RGB 16-bit 5:6:5, and Indexed 8-bit.
> + * RGB 16-bit 5:6:5 (prior to gen 9 LP), and Indexed 8-bit.
> * TBD: Add RGB64 case once its added in supported format list.
> */
> - switch (state->fb->format->format) {
> - case DRM_FORMAT_C8:
> - case DRM_FORMAT_RGB565:
> + if ((state->fb->format->format == DRM_FORMAT_C8) ||
> + (state->fb->format->format == DRM_FORMAT_RGB565 &&
> + !IS_GEN9_LP(dev_priv) )) {
I don't think BXT can do that.
> DRM_DEBUG_KMS("Unsupported pixel format %s for 90/270!\n",
> drm_get_format_name(state->fb->format->format,
> &format_name));
> return -EINVAL;
> -
> - default:
> - break;
> }
> }
>
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-06-07 17:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 17:45 [PATCH] drm/i915/glk: RGB565 planes now allow 90/270 rotation clinton.a.taylor
2017-06-07 17:55 ` Ville Syrjälä [this message]
2017-06-07 19:45 ` Clint Taylor
2017-06-07 18:03 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-06-08 11:45 ` [PATCH] " Szwichtenberg, Radoslaw
2017-06-08 15:30 ` Clint Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607175529.GN12629@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=clinton.a.taylor@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).