Re: [PATCH v2] lib/igt_kms: Fix override_mode handling

[Arkadiusz Hiler <arkadiusz.hiler@intel.com>]

On Fri, Jun 16, 2017 at 03:00:06PM +0100, Liviu Dudau wrote:
> From: Brian Starkey <brian.starkey@arm.com>
> 
> Changelog:
> - v2: removed the forced overwrite of output->config.default_mode
> - v1: original submission by Brian
> 
> igt_display_commit isn't refreshing all outputs anymore, which means
> that an override mode may never get picked up.
> 
> Instead of forcing a reprobe to handle copying the override_mode into
> default_mode, just change igt_output_get_mode() to return the
> override_mode if it's been set, and remove the old code which would
> directly overwrite default_mode.
> 
> This should be more robust, as igt_output_get_mode() will always return
> the correct mode, without needing the output to be reprobed.
> 
> This change means that output->config.default_mode always contains the
> "non-overridden" default mode.
> 
> Signed-off-by: Brian Starkey <brian.starkey@arm.com>
> Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>

... and pushed, thanks!


Also please remember of setting subject prefix to "PATCH i-g-t" as it
makes the changes easily trackable via filters and patchwork :-)

Excerpt from CONTRIBUTING:
-----------------------------------------------------------------------------
Please use --subject-prefix="PATCH i-g-t" so that i-g-t patches are easily
identified in the massive amount mails on intel-gfx. To ensure this is always
done, autogen.sh will run:

  git config format.subjectprefix "PATCH i-g-t"

on its first invocation.
-----------------------------------------------------------------------------

The autogen.sh thing is new addition.

-- 
Cheers,
Arek
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx