From: Antonio Argenziano <antonio.argenziano@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [i-g-t 2/2] tests/gem_reset_stats: Add client ban test
Date: Thu, 12 Oct 2017 15:10:37 -0700 [thread overview]
Message-ID: <20171012221037.9081-2-antonio.argenziano@intel.com> (raw)
In-Reply-To: <20171012221037.9081-1-antonio.argenziano@intel.com>
When a client gets a fixed amount of its contexts banned, will be
blocked from creating any new contexts itself. This patch adds a test
for this feature.
Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
Cc: Michel Thierry <michel.thierry@intel.com>
---
tests/gem_ctx_create.c | 10 +++++-----
tests/gem_reset_stats.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 52 insertions(+), 5 deletions(-)
diff --git a/tests/gem_ctx_create.c b/tests/gem_ctx_create.c
index ae0825a1..abe9a32e 100644
--- a/tests/gem_ctx_create.c
+++ b/tests/gem_ctx_create.c
@@ -45,7 +45,7 @@ static unsigned all_nengine;
static unsigned ppgtt_engines[16];
static unsigned ppgtt_nengine;
-static int __gem_context_create(int fd, struct drm_i915_gem_context_create *arg)
+static int __gem_context_create_local(int fd, struct drm_i915_gem_context_create *arg)
{
int ret = 0;
if (drmIoctl(fd, DRM_IOCTL_I915_GEM_CONTEXT_CREATE, arg))
@@ -255,7 +255,7 @@ static void maximum(int fd, int ncpus, unsigned mode)
err = -ENOMEM;
if (avail_mem > (count + 1) * ctx_size)
- err = __gem_context_create(fd, &create);
+ err = __gem_context_create_local(fd, &create);
if (err) {
igt_info("Created %lu contexts, before failing with '%s' [%d]\n",
count, strerror(-err), -err);
@@ -322,7 +322,7 @@ igt_main
igt_require_gem(fd);
memset(&create, 0, sizeof(create));
- igt_require(__gem_context_create(fd, &create) == 0);
+ igt_require(__gem_context_create_local(fd, &create) == 0);
gem_context_destroy(fd, create.ctx_id);
for_each_engine(fd, engine) {
@@ -347,7 +347,7 @@ igt_main
memset(&create, 0, sizeof(create));
create.ctx_id = rand();
create.pad = 0;
- igt_assert_eq(__gem_context_create(fd, &create), 0);
+ igt_assert_eq(__gem_context_create_local(fd, &create), 0);
igt_assert(create.ctx_id != 0);
gem_context_destroy(fd, create.ctx_id);
}
@@ -356,7 +356,7 @@ igt_main
memset(&create, 0, sizeof(create));
create.ctx_id = rand();
create.pad = 1;
- igt_assert_eq(__gem_context_create(fd, &create), -EINVAL);
+ igt_assert_eq(__gem_context_create_local(fd, &create), -EINVAL);
}
igt_subtest("maximum-mem")
diff --git a/tests/gem_reset_stats.c b/tests/gem_reset_stats.c
index edc40767..f51475a9 100644
--- a/tests/gem_reset_stats.c
+++ b/tests/gem_reset_stats.c
@@ -438,6 +438,50 @@ static void test_ban_ctx(const struct intel_execution_engine *e)
close(fd);
}
+#define CLIENT_BAN 4
+#define CTX_BAN 5
+static void test_client_ban(const struct intel_execution_engine *e)
+{
+ int fd_bad,fd_good;
+ struct local_drm_i915_reset_stats rs_bad, rs_good;
+ int ctx_bans;
+ uint32_t ctx_bad[CLIENT_BAN];
+ uint32_t test_ctx;
+
+ fd_bad = drm_open_driver(DRIVER_INTEL);
+ fd_good = drm_open_driver(DRIVER_INTEL);
+
+ assert_reset_status(fd_bad, fd_bad, 0, RS_NO_ERROR);
+ assert_reset_status(fd_good, fd_good, 0, RS_NO_ERROR);
+
+ for (int i = 0; i < CLIENT_BAN; i++) {
+ ctx_bad[i] = gem_context_create(fd_bad);
+ noop(fd_bad, ctx_bad[i], e);
+ assert_reset_status(fd_bad, fd_bad, ctx_bad[i], RS_NO_ERROR);
+
+ ctx_bans = CTX_BAN;
+ while (ctx_bans--)
+ inject_hang(fd_bad, ctx_bad[i], e, BAN);
+
+ igt_assert_eq(noop(fd_bad, ctx_bad[i], e), -EIO);
+
+ assert_reset_status(fd_bad, fd_bad, ctx_bad[i], RS_BATCH_ACTIVE);
+ igt_assert_eq(gem_reset_stats(fd_bad, ctx_bad[i], &rs_bad), 0);
+ igt_assert_eq(rs_bad.batch_active, CTX_BAN);
+ }
+
+ igt_assert_eq(__gem_context_create(fd_bad, &test_ctx), -EIO);
+ igt_info("Client banned after %d bad contexts\n", CLIENT_BAN);
+
+ igt_assert_lt(0, noop(fd_good, 0, e));
+ assert_reset_status(fd_good, fd_good, 0, RS_NO_ERROR);
+ igt_assert_eq(gem_reset_stats(fd_good, 0, &rs_good), 0);
+ igt_assert_eq(rs_good.batch_active, 0);
+
+ close(fd_bad);
+ close(fd_good);
+}
+
static void test_unrelated_ctx(const struct intel_execution_engine *e)
{
int fd1,fd2;
@@ -817,6 +861,9 @@ igt_main
igt_subtest_f("ban-ctx-%s", e->name)
RUN_CTX_TEST(test_ban_ctx(e));
+ igt_subtest_f("ban-client-%s", e->name)
+ RUN_CTX_TEST(test_client_ban(e));
+
igt_subtest_f("reset-count-%s", e->name)
RUN_TEST(test_reset_count(e, false));
--
2.14.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-12 22:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 22:10 [PATCH i-g-t 1/2] lib: Move __gem_context_create to common ioctl wrapper library Antonio Argenziano
2017-10-12 22:10 ` Antonio Argenziano [this message]
2017-10-12 22:21 ` [i-g-t 2/2] tests/gem_reset_stats: Add client ban test Antonio Argenziano
2017-10-12 22:32 ` Chris Wilson
2017-10-12 22:15 ` [PATCH i-g-t 1/2] lib: Move __gem_context_create to common ioctl wrapper library Chris Wilson
2017-10-12 22:23 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171012221037.9081-2-antonio.argenziano@intel.com \
--to=antonio.argenziano@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox