Re: [PATCH v2 2/2] drm/i915: add platform tag to WA

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Mon, Dec 04, 2017 at 09:51:47PM +0000, Lucas De Marchi wrote:
> v2: add more missing platform tags
> 
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_hdmi.c | 2 +-
>  drivers/gpu/drm/i915/intel_pm.c   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index 691600ce48c4..c42a6c672b73 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -1380,7 +1380,7 @@ static bool hdmi_12bpc_possible(const struct intel_crtc_state *crtc_state)
>  		}
>  	}
>  
> -	/* Display WA #1139 */
> +	/* Display WA #1139: glk */
>  	if (IS_GLK_REVID(dev_priv, 0, GLK_REVID_A1) &&
>  	    crtc_state->base.adjusted_mode.htotal > 5460)
>  		return false;
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 07ee5ad5a13f..f3384e5f5c49 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -8417,7 +8417,7 @@ static void cnp_init_clock_gating(struct drm_i915_private *dev_priv)
>  	if (!HAS_PCH_CNP(dev_priv))
>  		return;
>  
> -	/* Display WA #1181 */
> +	/* Display WA #1181: gen9,gen10 */

This one here should be "cnp" instead of gen actually.
That covers both gen9 and gen10 on this path because it actually
depends on pch and not on gen itself.

But I just saw on spec it mentions "skl" what is strange since this bit was
introduced with CNP PCH...

If you resend as cnp feel free to add my rv-b ;)

Thanks,
Rodrigo.

>  	I915_WRITE(SOUTH_DSPCLK_GATE_D, I915_READ(SOUTH_DSPCLK_GATE_D) |
>  		   CNP_PWM_CGE_GATING_DISABLE);
>  }
> -- 
> 2.14.3
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx