Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.auld@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: x86@kernel.org, Paulo Zanoni <paulo.r.zanoni@intel.com>,
	linux-kernel@vger.kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>
Subject: [PATCH v8 3/9] x86/early-quirks: replace the magical increment start values
Date: Mon, 11 Dec 2017 15:18:16 +0000	[thread overview]
Message-ID: <20171211151822.20953-4-matthew.auld@intel.com> (raw)
In-Reply-To: <20171211151822.20953-1-matthew.auld@intel.com>

Replace the magical +2, +9 etc. with +MB, which is far easier to read.

Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: x86@kernel.org
Cc: linux-kernel@vger.kernel.org
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Acked-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/kernel/early-quirks.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
index 6c1624889011..3cbb2c78a9df 100644
--- a/arch/x86/kernel/early-quirks.c
+++ b/arch/x86/kernel/early-quirks.c
@@ -428,9 +428,9 @@ static resource_size_t __init chv_stolen_size(int num, int slot, int func)
 	if (gms < 0x11)
 		return gms * MB(32);
 	else if (gms < 0x17)
-		return (gms - 0x11 + 2) * MB(4);
+		return (gms - 0x11) * MB(4) + MB(8);
 	else
-		return (gms - 0x17 + 9) * MB(4);
+		return (gms - 0x17) * MB(4) + MB(36);
 }
 
 static resource_size_t __init gen9_stolen_size(int num, int slot, int func)
@@ -446,7 +446,7 @@ static resource_size_t __init gen9_stolen_size(int num, int slot, int func)
 	if (gms < 0xf0)
 		return gms * MB(32);
 	else
-		return (gms - 0xf0 + 1) * MB(4);
+		return (gms - 0xf0) * MB(4) + MB(4);
 }
 
 struct intel_early_ops {
-- 
2.14.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-12-11 15:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-11 15:18 [PATCH v8 0/9] make stolen resource centric Matthew Auld
2017-12-11 15:18 ` [PATCH v8 1/9] x86/early-quirks: Extend Intel graphics stolen memory placement to 64bit Matthew Auld
2017-12-11 16:22   ` Ingo Molnar
2017-12-11 15:18 ` [PATCH v8 2/9] x86/early-quirks: export the stolen region as a resource Matthew Auld
2017-12-11 15:40   ` Chris Wilson
2017-12-11 16:23   ` Ingo Molnar
2017-12-11 15:18 ` Matthew Auld [this message]
2017-12-11 15:18 ` [PATCH v8 4/9] drm/i915: nuke the duplicated stolen discovery Matthew Auld
2017-12-11 15:18 ` [PATCH v8 5/9] drm/i915: make dsm struct resource centric Matthew Auld
2017-12-11 15:18 ` [PATCH v8 6/9] drm/i915: make reserved " Matthew Auld
2017-12-11 15:18 ` [PATCH v8 7/9] drm/i915: make mappable " Matthew Auld
2017-12-11 15:18 ` [PATCH v8 8/9] drm/i915: give stolen_usable_size a more suitable home Matthew Auld
2017-12-11 15:18 ` [PATCH v8 9/9] drm/i915: prefer resource_size_t for everything stolen Matthew Auld
2017-12-11 16:41 ` ✓ Fi.CI.BAT: success for make stolen resource centric (rev8) Patchwork
2017-12-11 18:06 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-12-12 10:43 ` [PATCH v8 0/9] make stolen resource centric Joonas Lahtinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171211151822.20953-4-matthew.auld@intel.com \
    --to=matthew.auld@intel.com \
    --cc=hpa@zytor.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paulo.r.zanoni@intel.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox