From: Ben Widawsky <ben@bwidawsk.net>
To: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: Question about CCS modifier on GLK
Date: Wed, 20 Dec 2017 08:46:45 -0800 [thread overview]
Message-ID: <20171220164645.GA11453@mail.bwidawsk.net> (raw)
In-Reply-To: <87y3m07tk6.fsf@collabora.co.uk>
On 17-12-17 22:45:13, Gabriel Krisman Bertazi wrote:
>
>Hi Ben and list folks,
>
>I've been investigating some CI failures with the kms_ccs testcase in
>the GLK hardware. The original bug is linked below, but there are other
>more basic tests failing when trying CCS on pipe C.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=104096
>
>The reason for the failure is very straightforward, the function
>skl_check_ccs_aux_surface() in intel_display.c rejects CCS modifiers for
>PIPE_C, since that is not supported for SKL, KBL and as far as I can
>tell APL as well.
>
>But, since I don't have the specs for GLK yet (it's not available in
>01.org), I can't tell if GLK will support it and the kernel must be
>changed or if the testcase itself is bogus. My money is on the later,
>but I could use a confirmation before writing down the patch.
>
>In short, does pipe C support render compression (ccs modifier) in glk?
>
>Thanks,
>
The hardware almost certainly works, but it wasn't validated. So we should
probably just disable it, and I've reviewed your patch. As Ville pointed out,
the series which was merged wasn't quite right to begin with, and it'd be
helpful if you could review his patches to fix it up.
>--
>Gabriel Krisman Bertazi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-12-20 16:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 0:45 Question about CCS modifier on GLK Gabriel Krisman Bertazi
2017-12-18 11:36 ` Ville Syrjälä
2017-12-20 16:46 ` Ben Widawsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220164645.GA11453@mail.bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=krisman@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox