From: Petri Latvala <petri.latvala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: [PATCH i-g-t 3/4] meson: Add quotes in assembler/test/run-test.sh
Date: Tue, 16 Jan 2018 13:13:05 +0200 [thread overview]
Message-ID: <20180116111306.7080-3-petri.latvala@intel.com> (raw)
In-Reply-To: <20180116111306.7080-1-petri.latvala@intel.com>
If the directories contain spaces, run-test.sh fails.
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
---
assembler/test/run-test.sh | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/assembler/test/run-test.sh b/assembler/test/run-test.sh
index b06e1044..f5e1a8fb 100644
--- a/assembler/test/run-test.sh
+++ b/assembler/test/run-test.sh
@@ -1,7 +1,7 @@
#!/bin/sh
-SRCDIR=${srcdir-`pwd`}
-BUILDDIR=${top_builddir-`pwd`}
+SRCDIR="${srcdir-`pwd`}"
+BUILDDIR="${top_builddir-`pwd`}"
test="TEST"
@@ -9,11 +9,11 @@ if [ -n "$1" ] ; then
test="$1"
fi
-test -d ${BUILDDIR}/test || mkdir ${BUILDDIR}/test/
+test -d "${BUILDDIR}/test" || mkdir "${BUILDDIR}/test/"
-${BUILDDIR}/intel-gen4asm -o ${BUILDDIR}/${test}.out $SRCDIR/${test}.g4a
-if cmp ${BUILDDIR}/${test}.out ${SRCDIR}/${test}.expected 2> /dev/null; then : ; else
+"${BUILDDIR}/intel-gen4asm" -o "${BUILDDIR}/${test}.out" "$SRCDIR/${test}.g4a"
+if cmp "${BUILDDIR}/${test}.out" "${SRCDIR}/${test}.expected" 2> /dev/null; then : ; else
echo "Output comparison for ${test}"
- diff -u ${SRCDIR}/${test}.expected ${test}.out
+ diff -u "${SRCDIR}/${test}.expected" "${test}.out"
exit 1;
fi
--
2.14.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-01-16 11:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 11:13 [PATCH i-g-t 1/4] meson: Build cnl_compute_wrpll Petri Latvala
2018-01-16 11:13 ` [PATCH i-g-t 2/4] meson: Add quotes in man/rst2man.sh Petri Latvala
2018-01-16 11:13 ` Petri Latvala [this message]
2018-01-16 11:13 ` [PATCH i-g-t 4/4] meson: Name the project intel-gpu-tools Petri Latvala
2018-01-17 9:30 ` [igt-dev] " Jani Nikula
2018-01-16 12:35 ` [PATCH i-g-t 1/4] meson: Build cnl_compute_wrpll Arkadiusz Hiler
2018-01-16 12:42 ` ✓ Fi.CI.BAT: success for series starting with [1/4] " Patchwork
2018-01-16 14:12 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116111306.7080-3-petri.latvala@intel.com \
--to=petri.latvala@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox