From: Ben Widawsky <ben@bwidawsk.net>
To: Rhys Kidd <rhyskidd@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 3/3] debugger: No longer rely on compatability define in intel_bufmgr.h
Date: Tue, 16 Jan 2018 08:29:05 -0800 [thread overview]
Message-ID: <20180116162905.GA8031@mail.bwidawsk.net> (raw)
In-Reply-To: <20180110042511.7551-3-rhyskidd@gmail.com>
On 18-01-09 23:25:11, Rhys Kidd wrote:
>Symbol rename from dri_* to drm_intel_* introduced a number of
>compatability defines within intel_bufmgr.h.
>
>Replace the old function with the new function, consistent with
>the balance of this file.
>
>Signed-off-by: Rhys Kidd <rhyskidd@gmail.com>
>---
> debugger/eudb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/debugger/eudb.c b/debugger/eudb.c
>index 8384950a..de37be52 100644
>--- a/debugger/eudb.c
>+++ b/debugger/eudb.c
>@@ -562,7 +562,7 @@ int main(int argc, char* argv[]) {
> if (fscanf(stdin, "%1d", &dh_handle) == 0)
> exit(1);
> }
>- scratch_bo = intel_bo_gem_create_from_name(bufmgr, "scratch", dh_handle);
>+ scratch_bo = drm_intel_bo_gem_create_from_name(bufmgr, "scratch", dh_handle);
> if (scratch_bo == NULL) {
> fprintf(stderr, "Couldn't flink buffer\n");
> abort();
The series looks good to me, but keep in mind that we never actually made this
work after Sandybridge, and even there, nobody ever ran it but me :-)
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
--
Ben Widawsky, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-01-16 16:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 4:25 [PATCH i-g-t 1/3] debugger: Convert to current intel_register_access_init() Rhys Kidd
2018-01-10 4:25 ` [PATCH i-g-t 2/3] debugger: Clean up register access helper in debug_rdata Rhys Kidd
2018-01-10 4:25 ` [PATCH i-g-t 3/3] debugger: No longer rely on compatability define in intel_bufmgr.h Rhys Kidd
2018-01-16 16:29 ` Ben Widawsky [this message]
2018-01-10 5:00 ` ✓ Fi.CI.BAT: success for series starting with [1/3] debugger: Convert to current intel_register_access_init() Patchwork
2018-01-10 6:48 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116162905.GA8031@mail.bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rhyskidd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox