From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: IGT development <igt-dev@lists.freedesktop.org>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH igt] igt/kms_frontbuffer_tracking: Show FBC status at the start of the wait
Date: Wed, 17 Jan 2018 11:35:15 +0100 [thread overview]
Message-ID: <20180117103515.GV2759@phenom.ffwll.local> (raw)
In-Reply-To: <20180116205219.22173-1-chris@chris-wilson.co.uk>
On Tue, Jan 16, 2018 at 08:52:19PM +0000, Chris Wilson wrote:
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Please remember to send igt patches to the new mailing list in the future.
Adding it.
-Daniel
> ---
> tests/kms_frontbuffer_tracking.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
> index 1601cab45..f35e40593 100644
> --- a/tests/kms_frontbuffer_tracking.c
> +++ b/tests/kms_frontbuffer_tracking.c
> @@ -792,11 +792,12 @@ static void __debugfs_read(const char *param, char *buf, int len)
>
> #define debugfs_read(p, arr) __debugfs_read(p, arr, sizeof(arr))
>
> -static bool fbc_is_enabled(void)
> +static bool fbc_is_enabled(int lvl)
> {
> char buf[128];
>
> debugfs_read("i915_fbc_status", buf);
> + igt_log(IGT_LOG_DOMAIN, lvl, "fbc_is_enabled()?\n%s", buf);
> return strstr(buf, "FBC enabled\n");
> }
>
> @@ -927,7 +928,7 @@ static bool fbc_stride_not_supported(void)
>
> static bool fbc_wait_until_enabled(void)
> {
> - return igt_wait(fbc_is_enabled(), 2000, 1);
> + return igt_wait(fbc_is_enabled(IGT_LOG_DEBUG), 2000, 1);
> }
>
> static bool psr_wait_until_enabled(void)
> @@ -1710,8 +1711,8 @@ static void do_status_assertions(int flags)
> igt_require(!fbc_not_enough_stolen());
> igt_require(!fbc_stride_not_supported());
> if (!fbc_wait_until_enabled()) {
> - fbc_print_status();
> - igt_assert_f(fbc_is_enabled(), "FBC disabled\n");
> + igt_assert_f(fbc_is_enabled(IGT_LOG_INFO),
> + "FBC disabled\n");
> }
>
> if (opt.fbc_check_compression)
> --
> 2.15.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-01-17 10:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 20:52 [PATCH igt] igt/kms_frontbuffer_tracking: Show FBC status at the start of the wait Chris Wilson
2018-01-16 21:24 ` ✓ Fi.CI.BAT: success for igt/kms_frontbuffer_tracking: Show FBC status at the start of the wait (rev5) Patchwork
2018-01-17 0:29 ` ✓ Fi.CI.IGT: " Patchwork
2018-01-17 10:35 ` Daniel Vetter [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-01-16 15:10 [PATCH igt] igt/kms_frontbuffer_tracking: Show FBC status at the start of the wait Chris Wilson
2018-01-17 10:34 ` Daniel Vetter
2018-01-05 13:41 Chris Wilson
2018-01-05 12:52 Chris Wilson
2017-12-21 20:54 Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180117103515.GV2759@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox