Re: [PATCH 1/3] drm/i915/dp: abstract rate array length limiting

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Thu, Feb 01, 2018 at 11:03:41AM +0000, Jani Nikula wrote:
> This will be useful later on. Also move the functions around to not need
> forward declarations in subsequent patches. No functional changes.
> 
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_dp.c | 38 ++++++++++++++++++++++----------------
>  1 file changed, 22 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 03d86ff9b805..3c1c11c1cd30 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -157,6 +157,28 @@ static void intel_dp_set_sink_rates(struct intel_dp *intel_dp)
>  	intel_dp->num_sink_rates = i;
>  }
>  
> +/* Get length of rates array potentially limited by max_rate. */
> +static int intel_dp_rate_limit_len(const int *rates, int len, int max_rate)
> +{
> +	int i;
> +
> +	/* Limit results by potentially reduced max rate */
> +	for (i = 0; i < len; i++) {
> +		if (rates[len - i - 1] <= max_rate)
> +			return len - i;
> +	}
> +
> +	return 0;
> +}
> +
> +/* Get length of common rates array potentially limited by max_rate. */
> +static int intel_dp_common_len_rate_limit(const struct intel_dp *intel_dp,
> +					  int max_rate)
> +{
> +	return intel_dp_rate_limit_len(intel_dp->common_rates,
> +				       intel_dp->num_common_rates, max_rate);
> +}
> +
>  /* Theoretical max between source and sink */
>  static int intel_dp_max_common_rate(struct intel_dp *intel_dp)
>  {
> @@ -328,22 +350,6 @@ static void intel_dp_set_common_rates(struct intel_dp *intel_dp)
>  	}
>  }
>  
> -/* get length of common rates potentially limited by max_rate */
> -static int intel_dp_common_len_rate_limit(struct intel_dp *intel_dp,
> -					  int max_rate)
> -{
> -	const int *common_rates = intel_dp->common_rates;
> -	int i, common_len = intel_dp->num_common_rates;
> -
> -	/* Limit results by potentially reduced max rate */
> -	for (i = 0; i < common_len; i++) {
> -		if (common_rates[common_len - i - 1] <= max_rate)
> -			return common_len - i;
> -	}
> -
> -	return 0;
> -}
> -
>  static bool intel_dp_link_params_valid(struct intel_dp *intel_dp, int link_rate,
>  				       uint8_t lane_count)
>  {
> -- 
> 2.11.0
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx