Re: [PATCH] drm/i915: Deprecate I915_SET_COLORKEY_NONE

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Fri, Feb 02, 2018 at 09:17:08PM +0000, Chris Wilson wrote:
> Quoting Ville Syrjala (2018-02-02 20:42:31)
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > Deprecate the silly I915_SET_COLORKEY_NONE flag. The obvious
> > way to disable colorkey is to just set flags to 0, which is
> > exactly what the intel ddx has been doing all along.
> 
> I can confirm that I never realised the flag existed. Just not setting
> either the dst or src flags made sense to me.
>  
> > Currently when userspace sets the flags to 0, we end up in a
> > funny state where colorkey is disabled, but various colorkey
> > vs. scaling checks still consider colorkey to be enabled, and
> > thus we don't allow plane scaling to kick in.
> > 
> > In case there is some other userspace out there that actually
> > uses this flag (unlikely as this is an i915 specific uapi)
> > we'll keep on accepting it.
> > 
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Thanks. Pushed to dinq.

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx