public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "José Roberto de Souza" <jose.souza@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 2/5] drm/i915: keep AUX powered while PSR is enabled
Date: Tue, 13 Feb 2018 16:29:14 -0800	[thread overview]
Message-ID: <20180214002917.31252-2-jose.souza@intel.com> (raw)
In-Reply-To: <20180214002917.31252-1-jose.souza@intel.com>

Hardware can send AUX transactions by it self when PSR is enabled and it
expects that AUX is kept powered up.

From spec:

"Each DisplayPort Aux channel has an Aux IO Power Request. If an Aux
channel will not be used, it does not need to be powered up.

PSR spontaneously sends Aux transactions.  If PSR is enabled on a port,
then the associated Aux IO must be kept powered up."

BSpec: 4230
BSpec: 17722

Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/intel_psr.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
index 8b456e4e1b47..225fde979e57 100644
--- a/drivers/gpu/drm/i915/intel_psr.c
+++ b/drivers/gpu/drm/i915/intel_psr.c
@@ -516,6 +516,12 @@ void intel_psr_enable(struct intel_dp *intel_dp,
 		goto unlock;
 	}
 
+	/*
+	 * hardware can send AUX transactions by it self when PSR is enabled,
+	 * and it expects that AUX is kept powered up.
+	 */
+	intel_display_power_get(dev_priv, intel_dp->aux_power_domain);
+
 	dev_priv->psr.psr2_support = crtc_state->has_psr2;
 	dev_priv->psr.busy_frontbuffer_bits = 0;
 
@@ -656,6 +662,8 @@ void intel_psr_disable(struct intel_dp *intel_dp,
 	/* Disable PSR on Sink */
 	drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_EN_CFG, 0);
 
+	intel_display_power_put(dev_priv, intel_dp->aux_power_domain);
+
 	dev_priv->psr.enabled = NULL;
 	mutex_unlock(&dev_priv->psr.lock);
 
-- 
2.16.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-02-14  0:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-14  0:29 [PATCH 1/5] drm/i915: add and enable DP AUX CH mutex José Roberto de Souza
2018-02-14  0:29 ` José Roberto de Souza [this message]
2018-02-14  1:19   ` [PATCH 2/5] drm/i915: keep AUX powered while PSR is enabled Rodrigo Vivi
2018-02-14  0:29 ` [PATCH 3/5] drm/i915: Share PSR and PSR2 VSC setup José Roberto de Souza
2018-02-14  0:29 ` [PATCH 4/5] drm/i915: Replace magic number with macro defined by drm José Roberto de Souza
2018-02-14  0:29 ` [PATCH 5/5] drm/i915: Make use of unused variable in hsw_write_infoframe() José Roberto de Souza
2018-02-14 13:33   ` Ville Syrjälä
2018-02-14 13:37     ` Chris Wilson
2018-02-14 14:29       ` Ville Syrjälä
2018-02-16  8:41     ` Jani Nikula
2018-02-14  0:36 ` ✗ Fi.CI.BAT: failure for series starting with [1/5] drm/i915: add and enable DP AUX CH mutex Patchwork
2018-02-14  1:30 ` [PATCH 1/5] " Rodrigo Vivi
2018-02-14  2:30   ` Souza, Jose
2018-02-14 13:43   ` Ville Syrjälä
2018-02-14  7:32 ` Jani Nikula
2018-02-14  9:47 ` Jani Nikula
2018-02-14 16:21   ` Rodrigo Vivi
2018-02-14 16:37     ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180214002917.31252-2-jose.souza@intel.com \
    --to=jose.souza@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox