From: James Ausmus <james.ausmus@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [PATCH] drm/i915/cnl: Sync PCI ID with Spec.
Date: Wed, 14 Feb 2018 15:21:28 -0800 [thread overview]
Message-ID: <20180214232126.GF12467@jausmus-gentoo-dev6.jf.intel.com> (raw)
In-Reply-To: <20180208073219.27860-1-rodrigo.vivi@intel.com>
On Wed, Feb 07, 2018 at 11:32:19PM -0800, Rodrigo Vivi wrote:
> Add one missing PCI ID and sort them in a way
> that gets easier to review and compare against spec's
> table.
>
> When trying to sync libdrm and mesa id list with kernel
> and spec I noticed something was wrong and we were missing
> a pci id. So to make our lives easier when checking against
> spec let's simplify and sort like spec does.
>
> BSpec: 13621
>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: James Ausmus <james.ausmus@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Matches BSpec.
Reviewed-by: James Ausmus <james.ausmus@intel.com>
> ---
> include/drm/i915_pciids.h | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index 9e1fe6634424..0b2ba46fa00b 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -416,18 +416,19 @@
>
> /* CNL */
> #define INTEL_CNL_IDS(info) \
> - INTEL_VGA_DEVICE(0x5A52, info), \
> - INTEL_VGA_DEVICE(0x5A5A, info), \
> - INTEL_VGA_DEVICE(0x5A42, info), \
> - INTEL_VGA_DEVICE(0x5A4A, info), \
> INTEL_VGA_DEVICE(0x5A51, info), \
> INTEL_VGA_DEVICE(0x5A59, info), \
> INTEL_VGA_DEVICE(0x5A41, info), \
> INTEL_VGA_DEVICE(0x5A49, info), \
> - INTEL_VGA_DEVICE(0x5A71, info), \
> - INTEL_VGA_DEVICE(0x5A79, info), \
> + INTEL_VGA_DEVICE(0x5A52, info), \
> + INTEL_VGA_DEVICE(0x5A5A, info), \
> + INTEL_VGA_DEVICE(0x5A42, info), \
> + INTEL_VGA_DEVICE(0x5A4A, info), \
> + INTEL_VGA_DEVICE(0x5A50, info), \
> + INTEL_VGA_DEVICE(0x5A40, info), \
> INTEL_VGA_DEVICE(0x5A54, info), \
> INTEL_VGA_DEVICE(0x5A5C, info), \
> - INTEL_VGA_DEVICE(0x5A44, info)
> + INTEL_VGA_DEVICE(0x5A44, info), \
> + INTEL_VGA_DEVICE(0x5A4C, info)
>
> #endif /* _I915_PCIIDS_H */
> --
> 2.13.6
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2018-02-14 23:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 7:32 [PATCH] drm/i915/cnl: Sync PCI ID with Spec Rodrigo Vivi
2018-02-08 8:28 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-02-08 12:08 ` ✗ Fi.CI.IGT: warning " Patchwork
2018-02-14 23:21 ` James Ausmus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214232126.GF12467@jausmus-gentoo-dev6.jf.intel.com \
--to=james.ausmus@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox