✗ Fi.CI.CHECKPATCH: warning for drm/i915: expose RCS topology to userspace

[Patchwork <patchwork@emeril.freedesktop.org>]

== Series Details ==

Series: drm/i915: expose RCS topology to userspace
URL   : https://patchwork.freedesktop.org/series/38356/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
b98af10ebabc drm/i915: store all subslice masks
-:344: CHECK: spaces preferred around that '*' (ctx:VxV)
#344: FILE: drivers/gpu/drm/i915/intel_device_info.c:323:
+			eu_disabled_mask = (eu_disable >> (ss*8)) & eu_mask;
 			                                     ^

-:431: WARNING: line over 80 characters
#431: FILE: drivers/gpu/drm/i915/intel_device_info.c:432:
+				eu_disable[s] >> (ss * sseu->max_eus_per_subslice);

total: 0 errors, 1 warnings, 1 checks, 483 lines checked
64190a6df1db drm/i915/debugfs: reuse max slice/subslices already stored in sseu
0b54af63ab85 drm/i915/debugfs: add rcs topology entry
-:97: CHECK: Please don't use multiple blank lines
#97: FILE: drivers/gpu/drm/i915/intel_device_info.c:151:
+
+

total: 0 errors, 0 warnings, 1 checks, 62 lines checked
e23c14155944 drm/i915: add rcs topology to error state
63c93eac311d drm/i915: add query uAPI
-:79: WARNING: line over 80 characters
#79: FILE: drivers/gpu/drm/i915/i915_drv.c:2840:
+	DRM_IOCTL_DEF_DRV(I915_QUERY, i915_query_ioctl, DRM_UNLOCKED|DRM_RENDER_ALLOW),

-:79: CHECK: spaces preferred around that '|' (ctx:VxV)
#79: FILE: drivers/gpu/drm/i915/i915_drv.c:2840:
+	DRM_IOCTL_DEF_DRV(I915_QUERY, i915_query_ioctl, DRM_UNLOCKED|DRM_RENDER_ALLOW),
 	                                                            ^

-:84: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#84: 
new file mode 100644

-:117: WARNING: line over 80 characters
#117: FILE: drivers/gpu/drm/i915/i915_query.c:29:
+					struct drm_i915_query_item *query_item) = {

-:211: WARNING: line over 80 characters
#211: FILE: include/uapi/drm/i915_drm.h:379:
+#define DRM_IOCTL_I915_QUERY			DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_QUERY, struct drm_i915_query)

-:219: CHECK: Please don't use multiple blank lines
#219: FILE: include/uapi/drm/i915_drm.h:1620:
 
+

total: 0 errors, 4 warnings, 2 checks, 180 lines checked
23eb4ded07cd drm/i915: expose rcs topology through query uAPI
-:24: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#24: 
v3: Use !!(v & DRM_I915_BIT()) for uapi macros instead of custom shifts (Tvrtko)

-:26: WARNING: 'writting' may be misspelled - perhaps 'writing'?
#26: 
v4: factorize query item writting (Tvrtko)

-:82: WARNING: line over 80 characters
#82: FILE: drivers/gpu/drm/i915/i915_query.c:54:
+	total_length = sizeof(topo_info) + slice_length + subslice_length + eu_length;

total: 0 errors, 3 warnings, 0 checks, 131 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx