From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH igt] igt/kms_frontbuffer_tracking: Disable FBC testing for -ENODEV
Date: Tue, 6 Mar 2018 15:42:59 +0100 [thread overview]
Message-ID: <20180306144259.GL22212@phenom.ffwll.local> (raw)
In-Reply-To: <151912933947.4312.13558357558249191696@mail.alporthouse.com>
On Tue, Feb 20, 2018 at 12:22:19PM +0000, Chris Wilson wrote:
> Quoting Daniel Vetter (2018-02-20 12:17:18)
> > On Thu, Feb 15, 2018 at 09:21:47AM +0000, Chris Wilson wrote:
> > > Quoting Chris Wilson (2018-02-11 18:54:33)
> > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > >
> > > Poke, CI is still tripping over this...
> >
> > Can you give a bit more context about what's going on and how this
> > happens? Bugzilla or whatever ... I'm confused.
>
> i915_fbc_status():
> if (!HAS_FBC(dev_priv))
> return -ENODEV;
>
> So whenever CI is run on machines without FBC (all of its gen3-gen5
> machine, as the only ilk appears to be a desktop unless I missed one)
> buf is empty.
Oh, I entirely missed that we errno out the read right away in that case.
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2018-03-06 14:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-11 18:54 [PATCH igt] igt/kms_frontbuffer_tracking: Disable FBC testing for -ENODEV Chris Wilson
2018-02-15 9:21 ` Chris Wilson
2018-02-20 12:17 ` [igt-dev] " Daniel Vetter
2018-02-20 12:22 ` Chris Wilson
2018-03-06 14:42 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180306144259.GL22212@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox