From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org, dim-tools@lists.freedesktop.org
Cc: jani.nikula@intel.com, Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [DIM PATCH 1/3] dim: cleanup checkpatch_commit
Date: Tue, 13 Mar 2018 13:30:08 +0200 [thread overview]
Message-ID: <20180313113010.13078-1-jani.nikula@intel.com> (raw)
Remove some old cruft. Pass checkpatch parameters via a variable. No
functional changes.
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
dim | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/dim b/dim
index 45aec403a44e..81e2bc1511ac 100755
--- a/dim
+++ b/dim
@@ -1360,13 +1360,14 @@ function check_maintainer
# $1 is the git sha1 to check
function checkpatch_commit
{
- local commit cmd bug_lines non_i915_files rv
+ local commit rv checkpatch_options
commit=$1
- cmd="git show --pretty=email $commit"
+ checkpatch_options="-q --emacs --strict --show-types -"
git --no-pager log --oneline -1 $commit
- if ! $cmd | scripts/checkpatch.pl -q --emacs --strict --show-types -; then
+ if ! git show --pretty=email $commit |\
+ scripts/checkpatch.pl $checkpatch_options; then
rv=1
fi
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2018-03-13 11:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 11:30 Jani Nikula [this message]
2018-03-13 11:30 ` [DIM PATCH 2/3] dim: add checkpatch profiles to allow different checkpatch options Jani Nikula
2018-03-13 11:48 ` Daniel Vetter
2018-03-13 15:07 ` Jani Nikula
2018-03-14 6:29 ` Daniel Vetter
2018-03-14 8:57 ` Jani Nikula
2018-03-13 11:30 ` [DIM PATCH 3/3] dim: loosen some drm-intel checkpatch rules Jani Nikula
2018-03-13 11:55 ` Daniel Vetter
2018-03-14 9:03 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313113010.13078-1-jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=dim-tools@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox