Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: StanLis <stanislav.lisovskiy@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for Enabling content-type setting for HDMI displays. (rev4)
Date: Thu, 19 Apr 2018 12:58:34 -0000	[thread overview]
Message-ID: <20180419125834.12192.12448@emeril.freedesktop.org> (raw)
In-Reply-To: <20180419123854.32356-1-stanislav.lisovskiy@intel.com>

== Series Details ==

Series: Enabling content-type setting for HDMI displays. (rev4)
URL   : https://patchwork.freedesktop.org/series/41876/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
b77a9ab3cc9a drm: content-type property for HDMI connector
-:113: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#113: FILE: drivers/gpu/drm/drm_connector.c:1017:
+		drm_object_attach_property(&connector->base,
+			connector->dev->mode_config.content_type_property,

-:143: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#143: FILE: drivers/gpu/drm/drm_connector.c:1304:
+		drm_property_create_enum(dev, 0, "content type",
+				drm_content_type_enum_list,

-:146: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!dev->mode_config.content_type_property"
#146: FILE: drivers/gpu/drm/drm_connector.c:1307:
+	if (dev->mode_config.content_type_property == NULL)

total: 0 errors, 0 warnings, 3 checks, 172 lines checked
674d7cb399e9 i915: content-type property for HDMI connector

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-04-19 12:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-19 12:38 [PATCH v5 0/2] Enabling content-type setting for HDMI displays StanLis
2018-04-19 12:38 ` [PATCH v5 1/2] drm: content-type property for HDMI connector StanLis
2018-04-19 12:46   ` Hans Verkuil
2018-04-20  7:56   ` Daniel Vetter
2018-04-20  8:31     ` Lisovskiy, Stanislav
2018-04-20 15:27       ` [Intel-gfx] " Daniel Vetter
2018-04-23  6:44         ` Lisovskiy, Stanislav
2018-04-24 12:19           ` Daniel Vetter
2018-04-19 12:38 ` [PATCH v5 2/2] i915: " StanLis
2018-04-19 12:46   ` Hans Verkuil
2018-04-19 12:58 ` Patchwork [this message]
2018-04-19 13:14 ` ✓ Fi.CI.BAT: success for Enabling content-type setting for HDMI displays. (rev4) Patchwork
2018-04-19 18:03 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180419125834.12192.12448@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=stanislav.lisovskiy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox