From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Manasi Navare <manasi.d.navare@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/dp: Rename the edp_sdp_header as dp_sdp_header
Date: Fri, 27 Apr 2018 17:12:24 +0300 [thread overview]
Message-ID: <20180427141224.GA23723@intel.com> (raw)
In-Reply-To: <1524770868-16869-1-git-send-email-manasi.d.navare@intel.com>
On Thu, Apr 26, 2018 at 12:27:48PM -0700, Manasi Navare wrote:
> No functional changes in this patch.
>
> The SDP Header is a generic header for secondary data packets for
> both eDP and DP so call it dp_sdp_header. This header gets used for
> different SDP types already defined.
> Also header bytes 2 and 3 are secondary data packet specific header bytes.
> So change the comment to indicate the same.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
Pushed to drm-misc-next. Thanks for the patch.
> ---
> include/drm/drm_dp_helper.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 91c9bcd..2d55036 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -977,18 +977,18 @@ int drm_dp_bw_code_to_link_rate(u8 link_bw);
> #define DP_SDP_VSC_EXT_CEA 0x21 /* DP 1.4 */
> /* 0x80+ CEA-861 infoframe types */
>
> -struct edp_sdp_header {
> +struct dp_sdp_header {
> u8 HB0; /* Secondary Data Packet ID */
> u8 HB1; /* Secondary Data Packet Type */
> - u8 HB2; /* 7:5 reserved, 4:0 revision number */
> - u8 HB3; /* 7:5 reserved, 4:0 number of valid data bytes */
> + u8 HB2; /* Secondary Data Packet Specific header, Byte 0 */
> + u8 HB3; /* Secondary Data packet Specific header, Byte 1 */
> } __packed;
>
> #define EDP_SDP_HEADER_REVISION_MASK 0x1F
> #define EDP_SDP_HEADER_VALID_PAYLOAD_BYTES 0x1F
>
> struct edp_vsc_psr {
> - struct edp_sdp_header sdp_header;
> + struct dp_sdp_header sdp_header;
> u8 DB0; /* Stereo Interface */
> u8 DB1; /* 0 - PSR State; 1 - Update RFB; 2 - CRC Valid */
> u8 DB2; /* CRC value bits 7:0 of the R or Cr component */
> --
> 2.7.4
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2018-04-27 14:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 19:27 [PATCH] drm/dp: Rename the edp_sdp_header as dp_sdp_header Manasi Navare
2018-04-27 9:27 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-04-27 11:48 ` ✓ Fi.CI.IGT: " Patchwork
2018-04-27 14:12 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180427141224.GA23723@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=manasi.d.navare@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox