From: Daniel Vetter <daniel@ffwll.ch>
To: Lucas De Marchi <lucas.de.marchi@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
intel-gfx@lists.freedesktop.org, dim-tools@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] dim: replace pipe commands with single sed
Date: Sat, 12 May 2018 21:44:43 +0200 [thread overview]
Message-ID: <20180512194443.GY28661@phenom.ffwll.local> (raw)
In-Reply-To: <CAKi4VAKv9OgBLPj9Zu7Th6AazomqXEd7_WVUAEDmQaut-ioKnQ@mail.gmail.com>
On Wed, May 09, 2018 at 04:32:53PM -0700, Lucas De Marchi wrote:
> Now CC the right mailing list. The way dim sets up the repository you
> can't have individual git configs, e.g. to set a different
> sendemail.to for dim-tools :(
>
> Lucas De Marchi
>
> On Wed, May 9, 2018 at 2:28 PM, Lucas De Marchi
> <lucas.demarchi@intel.com> wrote:
> > A single sed can do the job of taking the second line after a match and
> > it looks simpler.
> >
> > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> > ---
> >
> > I noticed this while reviewing "[PATCH 2/4] dim: shut up sed broken pipe
> > noise in apply-pull".
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> >
> > dim | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/dim b/dim
> > index 6b684ba5308c..f7cf255db3e1 100755
> > --- a/dim
> > +++ b/dim
> > @@ -924,7 +924,7 @@ function dim_apply_pull
> >
> > cat > $file
> >
> > - pull_branch=$(sed -e '0,/[gG]it repository at:$/d' $file | head -n 2 | tail -n 1)
> > + pull_branch=$(sed -ne '/[gG]it repository at:$/{n;n;p}' $file)
> >
> > if [[ -z "$pull_branch" ]] ; then
> > echoerr "no pull request found"
> > --
> > 2.17.0
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>
>
> --
> Lucas De Marchi
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-05-12 19:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 21:28 [PATCH] dim: replace pipe commands with single sed Lucas De Marchi
2018-05-09 23:32 ` Lucas De Marchi
2018-05-12 19:44 ` Daniel Vetter [this message]
2018-05-17 9:13 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180512194443.GY28661@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dim-tools@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.de.marchi@gmail.com \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox