Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/i915/i915_reg.h: fix the checkpatch SPACE_BEFORE_TAB issues
Date: Thu, 14 Jun 2018 10:26:20 -0700	[thread overview]
Message-ID: <20180614172617.GF8374@intel.com> (raw)
In-Reply-To: <20180612235654.7914-3-paulo.r.zanoni@intel.com>

On Tue, Jun 12, 2018 at 04:56:53PM -0700, Paulo Zanoni wrote:
> Since I'm touching the file I might as well fix this class of errors
> since they are just a few. Also drive-by fix the styling of the
> VLV_TURBO_SOC_OVERRIDE definitions instead of just the spaces before
> the tabs.
> 
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/i915/i915_reg.h | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 5e1d391b74db..f9a7cc5da5d8 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -1141,11 +1141,11 @@ enum i915_power_well_id {
>  #define   FB_FMAX_VMIN_FREQ_LO_SHIFT		27
>  #define   FB_FMAX_VMIN_FREQ_LO_MASK		0xf8000000
>  
> -#define VLV_TURBO_SOC_OVERRIDE	0x04
> -#define 	VLV_OVERRIDE_EN	1
> -#define 	VLV_SOC_TDP_EN	(1 << 1)
> -#define 	VLV_BIAS_CPU_125_SOC_875 (6 << 2)
> -#define 	CHV_BIAS_CPU_50_SOC_50 (3 << 2)
> +#define VLV_TURBO_SOC_OVERRIDE		0x04
> +#define   VLV_OVERRIDE_EN		1
> +#define   VLV_SOC_TDP_EN		(1 << 1)
> +#define   VLV_BIAS_CPU_125_SOC_875	(6 << 2)
> +#define   CHV_BIAS_CPU_50_SOC_50	(3 << 2)
>  
>  /* vlv2 north clock has */
>  #define CCK_FUSE_REG				0x8
> @@ -2412,7 +2412,7 @@ enum i915_power_well_id {
>  #define   DERRMR_PIPEA_SPR_FLIP_DONE	(1 << 2)
>  #define   DERRMR_PIPEA_VBLANK		(1 << 3)
>  #define   DERRMR_PIPEA_HBLANK		(1 << 5)
> -#define   DERRMR_PIPEB_SCANLINE 	(1 << 8)
> +#define   DERRMR_PIPEB_SCANLINE		(1 << 8)
>  #define   DERRMR_PIPEB_PRI_FLIP_DONE	(1 << 9)
>  #define   DERRMR_PIPEB_SPR_FLIP_DONE	(1 << 10)
>  #define   DERRMR_PIPEB_VBLANK		(1 << 11)
> @@ -7567,7 +7567,7 @@ enum {
>  #define  TRANS_VBLANK_END_SHIFT		16
>  #define  TRANS_VBLANK_START_SHIFT	0
>  #define _PCH_TRANS_VSYNC_A		0xe0014
> -#define  TRANS_VSYNC_END_SHIFT	 	16
> +#define  TRANS_VSYNC_END_SHIFT		16
>  #define  TRANS_VSYNC_START_SHIFT	0
>  #define _PCH_TRANS_VSYNCSHIFT_A		0xe0028
>  
> -- 
> 2.14.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-06-14 17:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-12 23:56 [PATCH 0/3] Some checkpatch fixes for i915_reg.h Paulo Zanoni
2018-06-12 23:56 ` [PATCH 1/3] drm/i915/i915_reg.h: fix the checkpatch SPACING issues Paulo Zanoni
2018-06-14 17:25   ` Rodrigo Vivi
2018-06-18 18:09   ` [PATCH v2 " Paulo Zanoni
2018-06-18 19:45     ` Jani Nikula
2018-06-18 23:15       ` Paulo Zanoni
2018-06-12 23:56 ` [PATCH 2/3] drm/i915/i915_reg.h: fix the checkpatch SPACE_BEFORE_TAB issues Paulo Zanoni
2018-06-14 17:26   ` Rodrigo Vivi [this message]
2018-06-12 23:56 ` [PATCH 3/3] drm/i915/i915_reg.h: fix the checkpatch MACRO_ARG_PRECEDENCE issues Paulo Zanoni
2018-06-14 17:26   ` Rodrigo Vivi
2018-06-13  0:38 ` ✗ Fi.CI.CHECKPATCH: warning for Some checkpatch fixes for i915_reg.h Patchwork
2018-06-13  0:58 ` ✓ Fi.CI.BAT: success " Patchwork
2018-06-13  3:47 ` ✓ Fi.CI.IGT: " Patchwork
2018-06-18 18:15 ` ✗ Fi.CI.CHECKPATCH: warning for Some checkpatch fixes for i915_reg.h (rev2) Patchwork
2018-06-18 18:31 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-06-18 20:17 ` ✓ Fi.CI.BAT: success " Patchwork
2018-06-18 22:59 ` ✓ Fi.CI.IGT: " Patchwork
2018-06-19  0:29 ` Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180614172617.GF8374@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox