From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] RFC drm/i915: Mark runtime_pm as a special class of lock
Date: Thu, 12 Jul 2018 10:37:59 +0200 [thread overview]
Message-ID: <20180712083759.GJ3008@phenom.ffwll.local> (raw)
In-Reply-To: <153138441200.10340.5673768105990363378@skylake-alporthouse-com>
On Thu, Jul 12, 2018 at 09:33:32AM +0100, Chris Wilson wrote:
> Quoting Chris Wilson (2018-07-12 09:20:37)
>
> It needs to be equally on runtime_pm_get.
Just wanted to complain about "what if we know there's someone holding an
rpm ref already?", but then remembered that this is what we have the
_if_in_use and _noresume variants for.
So a might_lock in runtime_pm_get sounds perfect.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-07-12 8:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 8:20 [PATCH] RFC drm/i915: Mark runtime_pm as a special class of lock Chris Wilson
2018-07-12 8:33 ` Chris Wilson
2018-07-12 8:37 ` Daniel Vetter [this message]
2018-07-12 8:36 ` [PATCH v2] " Chris Wilson
2018-07-12 8:41 ` Chris Wilson
2018-07-12 12:58 ` Daniel Vetter
2018-07-13 13:29 ` Chris Wilson
2018-08-06 15:58 ` Daniel Vetter
2018-07-12 9:40 ` ✗ Fi.CI.SPARSE: warning for RFC drm/i915: Mark runtime_pm as a special class of lock (rev2) Patchwork
2018-07-12 10:12 ` ✓ Fi.CI.BAT: success " Patchwork
2018-07-12 10:14 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180712083759.GJ3008@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox