From: Tvrtko Ursulin <tursulin@ursulin.net>
To: igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: [PATCH i-g-t 3/4] trace.pl: Bring back timeline stacking
Date: Thu, 19 Jul 2018 10:36:00 +0100 [thread overview]
Message-ID: <20180719093601.11788-4-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <20180719093601.11788-1-tvrtko.ursulin@linux.intel.com>
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Bring back the button which expands/stacks overlapping timeline boxes.
We default to no stacking, but sometimes expanding the view can be useful,
especially with deep request pipelines.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
scripts/trace.pl | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/scripts/trace.pl b/scripts/trace.pl
index 59f6d32dc3c8..1924333e12b6 100755
--- a/scripts/trace.pl
+++ b/scripts/trace.pl
@@ -935,6 +935,7 @@ Boxes are in format 'ctx-id/seqno'.
<p>
Use Ctrl+scroll-action to zoom-in/out and scroll-action or dragging to move around the timeline.
</p>
+<button onclick="toggleStacking()">Toggle overlap stacking</button>
</td>
</tr>
</table>
@@ -1284,6 +1285,12 @@ print <<ENDHTML;
// Create a Timeline
var timeline = new vis.Timeline(container, items, groups, options);
+
+ function toggleStacking() {
+ options.stack = !options.stack;
+ options.stackSubgroups = !options.stackSubgroups;
+ timeline.setOptions(options);
+ }
ENDHTML
print <<ENDHTML;
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-07-19 9:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 9:35 [PATCH i-g-t 0/4] trace.pl fixes and improvements Tvrtko Ursulin
2018-07-19 9:35 ` [PATCH i-g-t 1/4] trace.pl: Context save only applies to last request of a bunch Tvrtko Ursulin
2018-07-27 21:37 ` John Harrison
2018-08-02 10:29 ` [igt-dev] " Tvrtko Ursulin
2018-07-19 9:35 ` [PATCH i-g-t 2/4] trace.pl: Fix request split mode Tvrtko Ursulin
2018-07-27 21:43 ` John Harrison
2018-07-19 9:36 ` Tvrtko Ursulin [this message]
2018-07-27 21:47 ` [PATCH i-g-t 3/4] trace.pl: Bring back timeline stacking John Harrison
2018-08-02 10:38 ` Tvrtko Ursulin
2018-07-19 9:36 ` [PATCH i-g-t 4/4] trace.pl: Fix frequency timeline Tvrtko Ursulin
2018-07-27 22:17 ` John Harrison
2018-08-02 10:42 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719093601.11788-4-tvrtko.ursulin@linux.intel.com \
--to=tursulin@ursulin.net \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox