public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/2] drm: drm/i915: Add connector property to limit max bpc
Date: Sat, 25 Aug 2018 01:09:35 -0000	[thread overview]
Message-ID: <20180825010935.28782.60761@emeril.freedesktop.org> (raw)
In-Reply-To: <20180825010217.7612-1-radhakrishna.sripada@intel.com>

== Series Details ==

Series: series starting with [v3,1/2] drm: drm/i915: Add connector property to limit max bpc
URL   : https://patchwork.freedesktop.org/series/48695/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
cf2501ba38fa drm: drm/i915: Add connector property to limit max bpc
-:17: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#17: 
connector property to make sure that bpc does not exceed the configured value.

-:125: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!prop"
#125: FILE: drivers/gpu/drm/i915/intel_modes.c:146:
+	if (prop == NULL) {

-:127: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!prop"
#127: FILE: drivers/gpu/drm/i915/intel_modes.c:148:
+		if (prop == NULL)

total: 0 errors, 1 warnings, 2 checks, 102 lines checked
7855b6acf894 drm/i915: Allow "max bpc" property to limit pipe_bpp
-:30: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#30: FILE: drivers/gpu/drm/i915/intel_display.c:10789:
+connected_sink_max_bpp(struct drm_connector_state *conn_state,
+			     struct intel_crtc_state *pipe_config)

-:35: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#35: FILE: drivers/gpu/drm/i915/intel_display.c:10794:
+		pipe_config->pipe_bpp = 8*3;
 		                         ^

-:39: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#39: FILE: drivers/gpu/drm/i915/intel_display.c:10798:
+		pipe_config->pipe_bpp = 10*3;
 		                          ^

-:42: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#42: FILE: drivers/gpu/drm/i915/intel_display.c:10801:
+		pipe_config->pipe_bpp = 12*3;
 		                          ^

total: 0 errors, 0 warnings, 4 checks, 37 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-08-25  1:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-25  1:02 [PATCH v3 1/2] drm: drm/i915: Add connector property to limit max bpc Radhakrishna Sripada
2018-08-25  1:02 ` [PATCH v3 2/2] drm/i915: Allow "max bpc" property to limit pipe_bpp Radhakrishna Sripada
2018-08-25  1:09 ` Patchwork [this message]
2018-08-25  1:29 ` ✓ Fi.CI.BAT: success for series starting with [v3,1/2] drm: drm/i915: Add connector property to limit max bpc Patchwork
2018-08-25  2:20 ` ✓ Fi.CI.IGT: " Patchwork
2018-08-27 13:31 ` [PATCH v3 1/2] " Ville Syrjälä
2018-08-29 22:57   ` Radhakrishna Sripada
2018-08-30 13:38     ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180825010935.28782.60761@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=radhakrishna.sripada@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox